Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature requests for Test Result panel #193589

Closed
eleanorjboyd opened this issue Sep 20, 2023 · 13 comments · Fixed by #194852 or #200272
Closed

Feature requests for Test Result panel #193589

eleanorjboyd opened this issue Sep 20, 2023 · 13 comments · Fixed by #194852 or #200272
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded

Comments

@eleanorjboyd
Copy link
Member

eleanorjboyd commented Sep 20, 2023

As python moves to use the Test Result panel, there are a few feature requests I thought might make the experience better. Open to your thoughts / feedback as I don't understand all the use cases for this panel! Thanks

  1. When you click on a test that has succeeded there is no change in the display, this felt confusing to me because it doesn't signal to the user that there was no output from this test. It also may make people may get mixed up because in the list the successful test is highlighted but the output shown is from a failed test.
sucess-test-result-display.mov
  1. ✅ (complete) The output in the test result panel is not searchable when you have the test run dropdown selected. I think our users would value being able to search through this output

when I press cmd+F with the different test header selected I get a search box from one but not the other
image
image

  1. I found myself frequently wanting to click on a single test then go back to the whole test run output. I kept getting confused when clicking on the Test Run item in the list collapsed the block vs open the output. This is just different from the individual tests which clicking on them loads their output. I know you can right-click on the TestRun to get back there but it is not very discoverable. (resolved)
image
@connor4312
Copy link
Member

I found myself frequently wanting to click on a single test then go back to the whole test run output. I kept getting confused when clicking on the Test Run item in the list collapsed the block vs open the output. This is just different from the individual tests which clicking on them loads their output. I know you can right-click on the TestRun to get back there but it is not very discoverable.

You can also click the "terminal" icon in the inline actions. There's not a great way to handle this without making it hard to figure out how to collapse/expand the item.

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Sep 20, 2023
@eleanorjboyd
Copy link
Member Author

Ah yes, that makes sense I missed that icon initially. Thanks

@connor4312
Copy link
Member

The find widget (2) is now available in the Test Results terminal

@eleanorjboyd
Copy link
Member Author

Thank you @connor4312! One additional ask, I am seeing the find widget work when I click on a specific test but not when viewing the entire output from the test run, could we get it in both places?

Screenshot 2023-11-27 at 12 08 48 PM Screenshot 2023-11-27 at 12 08 40 PM

@connor4312
Copy link
Member

connor4312 commented Nov 28, 2023

@eleanorjboyd the find widget always worked in the former case where we show a text editor. Can you confirm that you're on the latest version of VS Code Insiders?

Kapture 2023-11-27 at 20 30 24

@connor4312 connor4312 modified the milestones: November 2023, December 2023 Nov 29, 2023
@eleanorjboyd
Copy link
Member Author

hm yeah I am seeing it now- sorry about that I am not sure what was wrong. Thanks

@hardeep-qa
Copy link

I have VS Code version 1.84.2 but still don't see the Find option in the TEST RESULTS section. I've tried with the Ctrl F command on the Windows machine.

@connor4312
Copy link
Member

connor4312 commented Nov 30, 2023

This is currently only on VS Code Insiders.

@hardeep-qa
Copy link

Ok Thanks, When it's going to released to the public?

@connor4312
Copy link
Member

We should release to stable in 6-7 days #198893

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 7, 2023
@eleanorjboyd
Copy link
Member Author

@connor4312 any thoughts on how to make the number 1 on my list more intuitive? I got feedback during TPIs that it was something that confused the team as they used the panel.

When you click on a test that has succeeded there is no change in the display, this felt confusing to me because it doesn't signal to the user that there was no output from this test. It also may make people may get mixed up because in the list the successful test is highlighted but the output shown is from a failed test.

@connor4312
Copy link
Member

connor4312 commented Dec 8, 2023

# 1 is what I fixed in my last PR. We now show the message/output associated with a successful test, if any, otherwise we show that there was no output

@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Jan 25, 2024
@eleanorjboyd
Copy link
Member Author

eleanorjboyd commented Jan 25, 2024

Thanks again for these feature adds it looks great!

@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verified Verification succeeded
Projects
None yet
5 participants