Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug console with DWARF debugging isn't printing the expected value #194232

Closed
Tyriar opened this issue Sep 26, 2023 · 6 comments · Fixed by microsoft/vscode-js-debug#1821
Closed

Debug console with DWARF debugging isn't printing the expected value #194232

Tyriar opened this issue Sep 26, 2023 · 6 comments · Fixed by microsoft/vscode-js-debug#1821
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
September 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2023

Testing #194071

See top left a and debug console a:

Image
@connor4312
Copy link
Member

This isn't something that really works, as we can't compile language X into code that we can execute to evaluate an expression.

I don't think we can wholesale disable the debug console input when in WASM locations, but we could print some more helpful error message.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 26, 2023

I kind of wasn't expecting it to work, what confused me the most was it was saying b was a thing

@connor4312
Copy link
Member

It looks like we actually can evaluate some expressions and the DWARF debugger includes lldb-eval. So we just need to delegate execution there, and complex expressions will error appropriately. Should be easily enough.

@connor4312 connor4312 mentioned this issue Sep 26, 2023
Merged
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Sep 26, 2023
@connor4312
fix: delegate wasm evaluation with dwarf
77e88ca 
Fixes microsoft/vscode#194232
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2023
@connor4312 connor4312 added this to the September 2023 milestone Sep 26, 2023
connor4312 added a commit to microsoft/vscode-js-debug that referenced this issue Sep 26, 2023
@connor4312
fix: delegate wasm evaluation with dwarf (#1821)
5a55d1d 
* fix: delegate wasm evaluation with dwarf

Fixes microsoft/vscode#194232

* update test fixture
@joyceerhl joyceerhl added the verified Verification succeeded label Sep 28, 2023
@joyceerhl
Copy link
Collaborator

🤔 all my fibonacci.c breakpoints are unbound now

@joyceerhl joyceerhl added verification-found Issue verification failed and removed verified Verification succeeded labels Sep 28, 2023
@connor4312
Copy link
Member

connor4312 commented Sep 28, 2023 •
edited
Loading

@joyceerhl can you confirm the DWARF debugging extension is installed and enabled, and if so set trace: true and share your logs?

@joyceerhl joyceerhl added verified Verification succeeded and removed verification-found Issue verification failed labels Sep 28, 2023
@joyceerhl
Copy link
Collaborator

Works well, I forgot I'd disabled it for verifying another issue 🤦

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

fix: delegate wasm evaluation with dwarf microsoft/vscode-js-debug
3 participants
@Tyriar @connor4312 @joyceerhl