Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"workbench.action.compareEditor.swapSides" exceptions #204560

Closed
MasterInQuestion opened this issue Feb 7, 2024 · 4 comments
Closed

"workbench.action.compareEditor.swapSides" exceptions #204560

MasterInQuestion opened this issue Feb 7, 2024 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-untitled-editors Managing of untitled editors in workbench window
Milestone

Comments

@MasterInQuestion
Copy link

MasterInQuestion commented Feb 7, 2024

= "workbench.action.compareEditor.swapSides" may create Untitled files unnecessarily =

    Invoking "Compare: Swap Left and Right Editor Side" ("workbench.action.compareEditor.swapSides") on Untitled files comparison: may create new Untitled files unnecessarily.

----

Version: 1.86.0
Commit: 0504748
User Agent: Mozilla/5.0 (Linux; rv:999) Gecko/20100101 Firefox/999
Embedder: vscode.dev

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues confirmed Issue has been confirmed by VS Code Team member workbench-untitled-editors Managing of untitled editors in workbench window labels Feb 7, 2024
@bpasero bpasero added this to the February 2024 milestone Feb 7, 2024
bpasero added a commit that referenced this issue Feb 7, 2024
@bpasero bpasero closed this as completed in fd2db10 Feb 7, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Feb 7, 2024
@MasterInQuestion
Copy link
Author

    Thanks for the rapid response.

    Linguistic-wise, judging from the specific change: there appears to be severe over-fragmentation in the source.

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 8, 2024
@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Feb 13, 2024
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@MasterInQuestion, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version b2598b9 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Feb 22, 2024
@MasterInQuestion
Copy link
Author

MasterInQuestion commented Mar 3, 2024

= "workbench.action.compareEditor.swapSides" no-op on "workbench.files.action.compareWithSaved" diff =

    I noted when invoking this on comparison created by "File: Compare Active File with Saved" ("workbench.files.action.compareWithSaved"): seems to do nothing.

    ----

    Intentional..? (the UI icon for invoking under such context went missing in 1.88)

@vscodenpa vscodenpa removed the author-verification-requested Issues potentially verifiable by issue author label Mar 3, 2024
@MasterInQuestion MasterInQuestion changed the title "workbench.action.compareEditor.swapSides" may create Untitled files unnecessarily "workbench.action.compareEditor.swapSides" exceptions Mar 3, 2024
@MasterInQuestion
Copy link
Author

    @bpasero
    The issue has been updated.

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member diff-editor Diff editor issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-untitled-editors Managing of untitled editors in workbench window
Projects
None yet
Development

No branches or pull requests

4 participants