Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in error messages that aren’t formatted as markown links are not clickable #206469

Closed
TheBlckbird opened this issue Feb 28, 2024 · 10 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@TheBlckbird
Copy link

TheBlckbird commented Feb 28, 2024

Does this issue occur when all extensions are disabled?: Yes (I’m using rust-analyzer as an example but this is generally a problem with VSCode. See the rust-lang/rust-clippy#12229)

  • VS Code Version: 1.87.0-insider
  • OS Version: macOS 14.3.1 (23D60)

Steps to Reproduce:

  1. install rust-analyzer
  2. go to setttings and change Cargo Check Command to clippy
  3. create a new cargo project by using cargo new bug-report
  4. Add the following code to the main function and hover over the warning:
let mut a = 5;
let b = 3;

a = a + b;
  1. try to click on the link
@DonJayamanne
Copy link
Contributor

Thanks you for filing this issue,
Recording 2024-03-04 at 11 25 41 (3)

Unfortunately I'm unable to replicate this issue in the latest version of VS Code Insiders.

Please can you install the latest VS Code Insiders, disable all extensions except for rust-analyzer test again.
If this issue still persists, please ping here and we'll be happy to reopen this issue, or feel free to create a new one.

If you are able to repro this, please share a screen recording of the issue, you can try gigcap.dev or similar to capture screen recording.

@DonJayamanne DonJayamanne added *not-reproducible Issue cannot be reproduced by VS Code Team member as described editor-hover Editor mouse hover and removed triage-needed labels Mar 4, 2024
@TheBlckbird
Copy link
Author

TheBlckbird commented Mar 4, 2024

@DonJayamanne
I’m not talking about normal compiler diagnostics. Clippy (a linter for Rust) always includes a link in its error message for more details. (e.g. https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern) But it doesn’t format it as a Markdown link for reasons described in the mentioned issue. Without being able to click on it directly you have to first select it, then copy and paste it into your browser. This could be dramatically simplified.

Bildschirmaufnahme.2024-03-04.um.09.59.26.mov

My settings.json:

{
    "rust-analyzer.check.command": "clippy",
}

main.rs in a clean Cargo project:

fn main() {
    let mut a = 5;
    let b = 3;

    a = a + b;
}

@DonJayamanne DonJayamanne reopened this Mar 4, 2024
@DonJayamanne DonJayamanne assigned mjbvz and unassigned DonJayamanne Mar 4, 2024
@DonJayamanne DonJayamanne removed the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Mar 4, 2024
@mjbvz mjbvz assigned sandy081 and unassigned mjbvz Mar 4, 2024
@mjbvz mjbvz removed the editor-hover Editor mouse hover label Mar 4, 2024
@sandy081
Copy link
Member

sandy081 commented Mar 5, 2024

How is it rendered when you press f8?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Mar 5, 2024
@TheBlckbird
Copy link
Author

@sandy081 I‘ll answer you in a few hours, I’m currently not at home

@TheBlckbird
Copy link
Author

@sandy081 Nothing changes

@sandy081
Copy link
Member

sandy081 commented Mar 7, 2024

What do you mean by nothing changes? Does it open a inline peek view on pressing F8? Or you are pressing f8 when hover is open?

@TheBlckbird
Copy link
Author

TheBlckbird commented Mar 7, 2024

Bildschirmfoto 2024-03-07 um 16 19 18
@sandy081 The link is not clickable

@sandy081
Copy link
Member

/duplicate

#54272

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 15, 2024
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@TheBlckbird
Copy link
Author

oh wow, 2018...
Thanks Microsoft, I’m glad I made the switch to Zed

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants