Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown link to diagnostic #12229

Closed

Conversation

TheBlckbird
Copy link

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: changes the link in diagnostics to a markdown link so editors like VSCode can create a clickable link

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 5, 2024
@TheBlckbird
Copy link
Author

TheBlckbird commented Feb 6, 2024

Whoops, I just realized that I forgot something important. I’ll fix it later today.

@flip1995
Copy link
Member

flip1995 commented Feb 6, 2024

This doesn't work, as the command line output would now contain the lint twice. As our main focus of error messages and suggestions is the CLI, I can't accept this PR. VSCode and other editors should be able to parse links without relying on markdown formatting IMHO.

error: approximate value of `f{32, 64}::consts::PI` found
 --> main.rs:1:17
  |
1 | const PI: f32 = 3.14159;
  |                 ^^^^^^^
  |
  = help: consider using the constant directly
  = help: for further information visit [rust-lang.github.io/rust-clippy/master/index.html#approx_constant](https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant)
  = note: `#[deny(clippy::approx_constant)]` on by default

Thanks for trying to improve Clippy!

@flip1995 flip1995 closed this Feb 6, 2024
@TheBlckbird
Copy link
Author

TheBlckbird commented Feb 6, 2024

I think I‘ll open an issue in the VSCode repo

@TheBlckbird
Copy link
Author

microsoft/vscode#206469

@TheBlckbird TheBlckbird deleted the TheBlckbird-patch-1 branch March 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants