Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make expandable hover content accessible to screen reader users #207592

Closed
meganrogge opened this issue Mar 13, 2024 · 8 comments
Closed

make expandable hover content accessible to screen reader users #207592

meganrogge opened this issue Mar 13, 2024 · 8 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@meganrogge
Copy link
Contributor

We will want to indicate that the expand / contract context actions in a hover exist to screen reader users.

When these are present, we should add an AccessibililtyVerbositySetting and hint to the hover's aria label that tells a user to open a help dialog, where we can indicate these actions, what they do, and the keybindings.

Image

@meganrogge meganrogge added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality labels Mar 13, 2024
@meganrogge meganrogge added this to the April 2024 milestone Mar 13, 2024
@meganrogge
Copy link
Contributor Author

We will also probably want to support these actions in the accessible view, similar to what we do with next and previous in the chat response accessible view so users don't have to navigate bw the widget and the accessible view.

@meganrogge
Copy link
Contributor Author

@aiday-mar I'm not sure what the current status of this is. Should we work on this in May?

@aiday-mar
Copy link
Contributor

Hi @meganrogge thank you for pinging on this issue. The PR on making the hover expandable is not merged yet, we are planning on merging it beginning of next iteration. Here is the link #204721. Perhaps after this is done, we can look into making the hover more accessible?

@meganrogge meganrogge modified the milestones: April 2024, May 2024 Apr 17, 2024
@meganrogge meganrogge modified the milestones: May 2024, June 2024 Apr 29, 2024
@aiday-mar
Copy link
Contributor

fixed by: #212783

@benibenj benibenj added the unreleased Patch has not yet been released in VS Code Insiders label May 28, 2024
@aiday-mar aiday-mar added verification-needed Verification of issue is requested on-testplan and removed verification-needed Verification of issue is requested labels May 28, 2024
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label May 28, 2024
@vscodenpa
Copy link

Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting \closedWith someCommitSha, or directly add the insiders-released label if you know this has already been releaased

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label May 28, 2024
@aiday-mar
Copy link
Contributor

\closedWith 7f55a08

@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 28, 2024
@aiday-mar aiday-mar reopened this Jun 13, 2024
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jun 13, 2024
@aiday-mar aiday-mar added the insiders-released Patch has been released in VS Code Insiders label Jun 13, 2024
@Yoyokrazy Yoyokrazy added the verification-needed Verification of issue is requested label Jun 25, 2024
@alexr00 alexr00 added the ~verification-steps-needed Steps to verify are needed (with bot comment) label Jun 25, 2024
@vscodenpa
Copy link

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

@vscodenpa vscodenpa added verification-steps-needed Steps to verify are needed for verification and removed ~verification-steps-needed Steps to verify are needed (with bot comment) labels Jun 25, 2024
@aiday-mar
Copy link
Contributor

aiday-mar commented Jun 25, 2024

This issue has already been verified on a TPI the month before. It does not need further verification. I'll update the labels.

@aiday-mar aiday-mar added on-testplan verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants