Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing to add more information to the hover #204721

Closed
wants to merge 102 commits into from
Closed

Allowing to add more information to the hover #204721

wants to merge 102 commits into from

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Feb 8, 2024 •
edited
Loading

Fixes #195394

@aiday-mar aiday-mar self-assigned this Feb 8, 2024
@aiday-mar
adding the boolean extended
0a4bef1
@aiday-mar
on shift, we show the extended hover
be8a5c1
@aiday-mar
creating instead an api proposal
3d6459f
@aiday-mar
adding code in order to propagate the extended keyword
8727fa8
@aiday-mar
adding code in order to use insead an additional action, show extende…
818a6d0 
…d hover
@aiday-mar
making changes so one can transition to more extended information
3e6b577
@aiday-mar
making hover correctly appear
423994c
@aiday-mar
adding a setting and showing instead the extended hover information.
5c7b3d8
@aiday-mar
making chanegs
357e8bf
@aiday-mar
polishing the code
e85df6c
@aiday-mar
extending the hover
ab57fa9
@aiday-mar
adding the actions into a toolbar in the markdown hover when it can b…
d342e4b 
…e extended
@aiday-mar
adding code in order to align the actions
f90f526
@aiday-mar
changing the code so as to directly have the code inside of the markd…
c2e2a5e 
…own participant
@aiday-mar
refactoring the code
0f2f5cb
@aiday-mar
polishing the code
e6c0a45
@aiday-mar
polishing the code
5addb57
@aiday-mar
adding the disposable store into the markdown hover participant
b263f15
@aiday-mar
letting the disposable store be undefined
4c56bcb
@aiday-mar
adding the on contents changes into the extend or constract focused m…
a80074a 
…essage call
@aiday-mar
polish
5b337a6
@aiday-mar aiday-mar disabled auto-merge April 19, 2024 15:16
@aiday-mar aiday-mar closed this Apr 19, 2024
@starball5
Copy link

I'm a bit confused about the status. What happened? Is this not getting merged? What will happen next?

@aiday-mar
Copy link
Contributor Author

Hi @starball5 yes so the code has been merged albeit in a different PR here #210472. The two PRs differ by their memory management logic but essentially otherwise are the same.

@Hasan-Mir
Copy link

How can we enable it in vscode?

@aiday-mar
Copy link
Contributor Author

Hi @Hasan-Mir you can pull the editor hover verbosity proposed API by placing the following in your extension's package.json file:

 "enabledApiProposals": [
    "editorHoverVerbosityLevel"
  ]

and pulling the proposed API using the terminal command:

npx @vscode/dts dev

@microsoft microsoft locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hediet hediet hediet requested changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
April 2024
Development

Successfully merging this pull request may close these issues.

API for showing additional info in a hover
5 participants
@aiday-mar @starball5 @Hasan-Mir @hediet @vscodenpa