Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal chat: Consider UX for buttons when there are multiple chat blocks #207604

Closed
Tyriar opened this issue Mar 13, 2024 · 2 comments · Fixed by #209080
Closed

Terminal chat: Consider UX for buttons when there are multiple chat blocks #207604

Tyriar opened this issue Mar 13, 2024 · 2 comments · Fixed by #209080
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-chat Issues related to the terminal chat widget verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 13, 2024

When there are multiple code blocks we still just have "Run" and "Insert", but it's not clear that it will work on the first block only. Should we special case it such that if there are multiple code blocks the buttons change to "Run First" and "Insert First"?

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-chat Issues related to the terminal chat widget labels Mar 13, 2024
@Tyriar Tyriar added this to the March 2024 milestone Mar 13, 2024
@meganrogge
Copy link
Contributor

I wondered about this and thought we'd discussed forcing the LLM to give us only one code block, (or more strictly filtering its response) which would make this unnecessary.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 13, 2024

With the coming chat location I was thinking we'd keep the terminal chat as is, but make @terminal inside the chat view more verbose. It already almost always gives a single block unless you really push it in which case it's kind of expected to have multiple code blocks. I don't think we'd be able to gracefully handle all cases where there's more than one block by removing some of them, there are also other agents that can give whatever they want, so it'll always be an edge case.

@Tyriar Tyriar modified the milestones: March 2024, April 2024 Mar 22, 2024
@Tyriar Tyriar removed their assignment Mar 28, 2024
meganrogge added a commit that referenced this issue Mar 28, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 29, 2024
@Tyriar Tyriar added the verified Verification succeeded label Apr 24, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-chat Issues related to the terminal chat widget verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants