Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Extension Update Enhancements #208185

Closed
3 tasks done
sandy081 opened this issue Mar 20, 2024 · 7 comments
Closed
3 tasks done

Test Extension Update Enhancements #208185

sandy081 opened this issue Mar 20, 2024 · 7 comments

Comments

@sandy081
Copy link
Member

sandy081 commented Mar 20, 2024

Ref: #125417

Complexity: 5

Create Issue


Test Auto Updating Extensions while Updating VS Code

Set Up

Testing

  • Have your extension installed. Push an update to your extension to Marketplace.
  • Make sure extensions are updated while checking for VS Code updates - to test this - Trigger check for updates on VS Code.
  • When the newer version of the extension is not compatible with current version of VS Code but compatible with newer version of VS Code, test that extension will be updated. After updating, appropriate action is shown on the extension. For eg., Restart to Update action is shown if VS Code needs restart for updating. Please test the right action is shown in each platform.

Note: You can publish an extension that is not compatible with current insiders version but compatible with newer insiders version by adding date to vscode version in engine. This date should be later than older insiders version but before the newer insiders version. Eg:

"engines": {
		"vscode": "^1.87.0-20240219",
	}

Test Restarting Extensions on Update | Uninstall | Disable

  • You can now simply restart extensions when an extension is updated to a newer or another version. Also when you uninstalled the extension. This will update or remove the updated or uninstalled extension in the extension host. Test that this is working as expected.
  • Test that this should still show Reload Required action in Remote window.
@aeschli
Copy link
Contributor

aeschli commented Mar 25, 2024

I have started testing and will complete it tomorrow

@rebornix
Copy link
Member

This is very nice!

@roblourens
Copy link
Member

roblourens commented Mar 25, 2024

Do any of the Linux install methods support the same update flow that mac/win does, where it updates itself and restarts? I’m not sure whether this flow actually can work on Linux?

I did try it on Mac and it worked great

@joaomoreno
Copy link
Member

This feature doesn't need the full auto update flow to work. It works just fine on Linux, where for deb/rpm/archive we just notify the user that there's an available VS Code update. I've verified that when that happens, there's the following telemetry event fired: telemetry/galleryService:checkingForUpdates. Works great!

@roblourens
Copy link
Member

roblourens commented Mar 26, 2024

But it's not going to install the extension update at that time, because it wants to install the extension update at the same time it installs the vscode update, right? That never seemed to happen for me because vscode doesn't update itself in these scenarios.

@sandy081
Copy link
Member Author

When extensions auto update is enabled, VS Code updates the extension while checking the updates. Updating VS Code just acts as another trigger to update extensions, so they are not tightly coupled.

@roblourens
Copy link
Member

Oh, I see, thanks

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants