Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementations Code Lens For TypeScript #20832

Closed
mjbvz opened this issue Feb 17, 2017 · 7 comments · Fixed by #20784
Closed

Implementations Code Lens For TypeScript #20832

mjbvz opened this issue Feb 17, 2017 · 7 comments · Fixed by #20784
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues plan-item VS Code - planned item for upcoming typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 17, 2017

No description provided.

@mjbvz mjbvz added feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues labels Feb 17, 2017
@mjbvz mjbvz added this to the March 2017 milestone Feb 17, 2017
@mjbvz mjbvz self-assigned this Feb 17, 2017
@mjbvz mjbvz added plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested labels Mar 6, 2017
@kieferrm kieferrm mentioned this issue Mar 6, 2017
58 tasks
@isidorn
Copy link
Contributor

isidorn commented Mar 29, 2017

I tried setting "typescript.implementationsCodeLens.enabled": true - however there was no effect on the vscode worksace.
I only get typescript codelense if I set "typescript.referencesCodeLens.enabled": true, however implementationsCodeLens makes no difference.
What am I doing wrong here?

@chrmarti
Copy link
Contributor

It's not connected to the configuration change event. Will link a PR fixing that. Reopening so we can decide on what to do. /cc @kieferrm

@roblourens
Copy link
Member

Side question, is the implementation supposed to be highlighted like this?

image

@roblourens
Copy link
Member

I guess so, same color as used for 'find references', just... more

@isidorn
Copy link
Contributor

isidorn commented Mar 30, 2017

@chrmarti I still do not see this working in latest insiders.
Just wanted to let you know since i think your PR was merged

@chrmarti
Copy link
Contributor

Just checked and it seems to work for:

interface Foo {
    bar(): void;
}

class Baz implements Foo {
    bar() {
    }
}

new Baz().bar();

That shows as:
screen shot 2017-03-30 at 7 38 04 am

I wonder if bar() on the interface should also show an implementation. With the fix, the lenses now update with the configuration change without reload for me. (Closing for verification.)

@chrmarti
Copy link
Contributor

Verifier: This requires TypeScript 2.2.0 or higher to work.

@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues plan-item VS Code - planned item for upcoming typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants