Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay Inline Completion Audio Cues #208449

Closed
marrej opened this issue Mar 22, 2024 · 1 comment · Fixed by #210691
Closed

Delay Inline Completion Audio Cues #208449

marrej opened this issue Mar 22, 2024 · 1 comment · Fixed by #210691
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-signal Issues pertaining to accessibility signals feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@marrej
Copy link
Contributor

marrej commented Mar 22, 2024

TLDR: We got some reports that the inline suggest audio cues mask/annoy users when suggest dropdown is triggered, allowing users with screen readers to select when the cue should be played would be helpful.

Current state

Currently the inline completion audio cues are played right when the inline completion appears on screen. If a suggest dropdown triggers the inline completion, the alert cue is played at the time when the suggest dropdown is red. Causing annoyance and possible confusion for the users.

Proposal

Provide a optional setting for the inline suggest audio cues, that would allow to select when a cue is played.

  • When no suggest dropdown is rendered (playing audio cue, only if a suggest dropdown has been resolved and inline completion is shown)
  • Every time inline suggest is rendered (the current state)

This would allow the screen reader users to keep the audio cues, but decide whether and when they should be played.

@hediet hediet added feature-request Request for new features or functionality accessibility-signal Issues pertaining to accessibility signals labels Mar 25, 2024
@hediet hediet added this to the April 2024 milestone Mar 25, 2024
@hediet hediet added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 25, 2024
@hediet
Copy link
Member

hediet commented Apr 18, 2024

I don't think a setting is necessary here - when the suggest widget is visible, inline completion signals just shouldn't be played.

Verification steps:

  • Enable screen reader.
  • Notice that audio cues are played when inline suggestions are shown, except when the suggest widget is visible.

hediet added a commit that referenced this issue Apr 18, 2024
@hediet hediet added the verification-needed Verification of issue is requested label Apr 22, 2024
hediet added a commit that referenced this issue Apr 22, 2024
* Fixes #208449

* Fixes leak

* Fixes more leaks
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Apr 22, 2024
sergioengineer pushed a commit to sergioengineer/VimSCode that referenced this issue Apr 23, 2024
* Fixes microsoft#208449

* Fixes leak

* Fixes more leaks
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 23, 2024
@bpasero bpasero added the verified Verification succeeded label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues accessibility-signal Issues pertaining to accessibility signals feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants