Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double-click in text content of stack frame should take you to source #226855

Closed
andreamah opened this issue Aug 27, 2024 · 1 comment · Fixed by #226981
Closed

double-click in text content of stack frame should take you to source #226855

andreamah opened this issue Aug 27, 2024 · 1 comment · Fixed by #226981
Assignees
@connor4312
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2024

Comments

@andreamah
Copy link
Contributor

Testing #226684

When double-clicking on the source code in the stack frame, I feel like that should take you to the source code in the editor (like how it does when you do in the Go to Definition peek view.
@connor4312
Copy link
Member

Double click is not really an action we have in code editors since that can also create selections, but I'll make it so that ctrl+clicking on any word in the editor brings you to the full file instead of its definition

connor4312 added a commit that referenced this issue Aug 28, 2024
@connor4312
testing: call stack tpi refinements
40e586c 
Fixes #226855 - ctrl+click on words in files takes you to the source
Fixes #226863 - clicking file titles should toggle collapse
Fixes #226857 - add 'collapse all' button in peek
Fixes #226852 - name 'go to source' actions better
@connor4312 connor4312 mentioned this issue Aug 28, 2024
Merged
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Aug 28, 2024
@connor4312 connor4312 added this to the August 2024 milestone Aug 28, 2024
@connor4312 connor4312 added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed bug Issue identified by VS Code Team member as probable bug labels Aug 28, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2024
@benibenj benibenj added the verified Verification succeeded label Aug 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

testing: call stack tpi refinements microsoft/vscode
3 participants
@connor4312 @andreamah @benibenj