Moving text cursor cause an incorrect position in Chinese

[ikatyang]

• VSCode Version: 1.10.2
• OS Version: win7 & win10

Steps to Reproduce:

1. Press up arrow key ⬆️
2. Press down arrow key ⬇️

Chinese characters are actually 2-char width in monospace-font.

Test font: 文泉驛等寬正黑 ( download: wqy-zenhei.zip, this is an open-source font )

Test config settings.json

{
  "editor.fontFamily": "文泉驛等寬正黑"
}

Test case

一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890
一二三四五六七八九十
12345678901234567890

[alexdima]

Related - #22832 .. visibleColumnFromColumn should be made wide chars aware.

[wangweixuan]

Related #9989.

[alexdima]

To the verifier:

• make sure you have a font where a wide CJK character is painted with the widht of 2 latin characters. e.g. Inconsolata
• please also verify with the steps in Column selection with CJK character #9989 (comment)

[alexdima]

Fixed by PR #44259

[octref]

@alexandrudima #44878

[alexdima]

@octref Thank you for verifying, but I believe you have attempted to verify in a build that did not contain the fix (i.e. the behaviour you describe sounds a lot like what is on stable):