Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to log into a new account from the account menu if already logged into an account #229496

Closed
aiday-mar opened this issue Sep 24, 2024 · 1 comment · Fixed by #230746
Assignees
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan
Milestone

Comments

@aiday-mar
Copy link
Contributor

aiday-mar commented Sep 24, 2024

Testing #229420

  • So I am logged into my main account aiday-mar into VS Code.
  • I clicked on the account icon and opened the account menu
  • I can manage the trusted extensions for my main account from there
  • Maybe it would make sense to have a new entry in that menu to add another account since now this is supported.

Screenshot 2024-09-24 at 10 25 21

@TylerLeonhardt TylerLeonhardt added feature-request Request for new features or functionality authentication Issues with the Authentication platform labels Sep 25, 2024
@TylerLeonhardt TylerLeonhardt added this to the October 2024 milestone Sep 25, 2024
@TylerLeonhardt
Copy link
Member

This a tough one because "adding an account" doesn't matter to VS Code itself. It only really matters to extensions.

Additionally, It's very easy to support this for Microsoft, but for GitHub it's a bit challenging because scopes matter to GitHub. You have to sign in to your GitHub account for each set of scopes. For example:

  • GitHub Pull Requests asks for scopes: user:email repo workflow read:user
  • GitHub Copilot asks for scopes: user:email

So for an "add account" experience, how do we do that?

The the best answer I could come up with is to have an add account on here:
image

And keep track of the requests that each extension asks for.

Then when they add an account we use the last set of scopes that that extension has requested when making the request.

TylerLeonhardt added a commit that referenced this issue Oct 7, 2024
This option allows you to sign in to a new account and use if for an extension all in the same flow:

insert pic

Fixes #229496
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Oct 7, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 8, 2024
@TylerLeonhardt TylerLeonhardt added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Oct 21, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants