Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No completions on / #235084

Closed
jrieken opened this issue Dec 3, 2024 · 10 comments · Fixed by #235165
Closed

No completions on / #235084

jrieken opened this issue Dec 3, 2024 · 10 comments · Fixed by #235165
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 3, 2024

Testing #235021

  • trigger completions with ctrl+space
  • dismiss them
  • press / cos trigger character
  • 🐛 nothing
Screen.Recording.2024-12-03.at.09.58.30.mov
@Tyriar
Copy link
Member

Tyriar commented Dec 3, 2024

@jrieken do you have shell integration disabled (terminal.integrated.shellIntegration.enabled), or just the decorations on the left (terminal.integrated.shellIntegration.decorationsEnabled)?

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Dec 3, 2024
@Tyriar Tyriar removed their assignment Dec 3, 2024
@Tyriar Tyriar added this to the January 2025 milestone Dec 3, 2024
@jrieken
Copy link
Member Author

jrieken commented Dec 3, 2024

These are all my terminal settings (only decorations are off, but shell integration is default on)

  "terminal.integrated.confirmOnExit": "never",
  "terminal.integrated.enablePersistentSessions": false,
  "terminal.integrated.fontLigatures": true,
  "terminal.integrated.initialHint": false,
  "terminal.integrated.scrollback": 50000,
  "terminal.integrated.suggest.enabled": true,
  "terminal.integrated.suggest.enableExtensionCompletions": true,
  "terminal.integrated.shellIntegration.decorationsEnabled": "never",
  "terminal.integrated.showExitAlert": false,
  "terminal.integrated.stickyScroll.enabled": false,
  "terminal.integrated.tabs.enabled": true,
  "terminal.integrated.tabs.hideCondition": "never",
  "terminal.integrated.tabs.location": "left",
  "terminal.integrated.tabs.showActiveTerminal": "never",
  "terminal.integrated.windowsEnableConpty": false,

@Tyriar
Copy link
Member

Tyriar commented Dec 3, 2024

@jrieken FYI if you do use Windows, using "terminal.integrated.windowsEnableConpty": false will make the experience much worse. I think annoyingly some extensions set that to false in the past.

@meganrogge
Copy link
Contributor

This works for me on mac in Insider's

@meganrogge
Copy link
Contributor

Screen.Recording.2024-12-07.at.1.33.50.PM.mov

@meganrogge meganrogge modified the milestones: January 2025, November 2024 Dec 7, 2024
@jrieken jrieken reopened this Dec 9, 2024
@jrieken
Copy link
Member Author

jrieken commented Dec 9, 2024

@meganrogge It still doesn't work for me

@dbaeumer dbaeumer modified the milestones: November 2024, January 2025 Dec 9, 2024
@dbaeumer
Copy link
Member

dbaeumer commented Dec 9, 2024

Moving to January

@meganrogge
Copy link
Contributor

@jrieken have you disabled terminal persistent sessions ?

@jrieken
Copy link
Member Author

jrieken commented Dec 9, 2024

@meganrogge these are all my terminal settings: #235084 (comment)

@meganrogge
Copy link
Contributor

Likely will be fixed by #235165

@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants