Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can trigger terminal suggest even without shell integration #238380

Closed
meganrogge opened this issue Jan 21, 2025 · 0 comments · Fixed by #238385
Closed

can trigger terminal suggest even without shell integration #238380

meganrogge opened this issue Jan 21, 2025 · 0 comments · Fixed by #238385
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest verified Verification succeeded
Milestone
January 2025

Comments

@meganrogge
Copy link
Contributor

  1. have terminal suggest enabled
  2. open a subshell - for example, in a zsh terminal, type bash.
  3. trigger suggest with ctrl+space.
  4. 🐛 suggest is shown, but it's not aware of prompt input

cc @Tyriar

Image
@meganrogge meganrogge self-assigned this Jan 21, 2025
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Jan 21, 2025
@meganrogge meganrogge added this to the January 2025 milestone Jan 21, 2025
meganrogge added a commit that referenced this issue Jan 21, 2025
@meganrogge
fix #238380
5e2da22
meganrogge added a commit that referenced this issue Jan 21, 2025
@meganrogge
fix #238380
a87a39d
@meganrogge meganrogge mentioned this issue Jan 21, 2025
Merged
meganrogge added a commit that referenced this issue Jan 21, 2025
@meganrogge
fix #238380
32d0502
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 21, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 22, 2025
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

don't request terminal completions if cursor index < 0 microsoft/vscode
2 participants
@rzhao271 @meganrogge