[icon themes] Hide sidebar's Tree View/Explorer arrows

[ajitid]

As opened and closed folders can have different icons, the arrows should be given as an optional to get a minimalistic workbench theming (say for themes like Material Theme from Mattia Astorino or Nord theme)

[equinusocio]

Any update? i think this can be more easily a workbench setting to show/hide the arrow.

[equinusocio]

News? :)

[aeschli]

It would have to be part of the file icon theme to specify that (not a workbench preference)
But I currently have no time to implement it. PR are welcome. It new setting would be added to https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/themes/common/workbenchThemeService.ts#L48 and used by the file explorer.

[equinusocio]

+1

[aeschli]

Thanks for the PR, @tam5!

[equinusocio]

@tam5 Thank you.

[equinusocio]

@aeschli When will this PR be shipped with the insiders build?

[aeschli]

Yes, it's already in the latest insiders.

[equinusocio]

@aeschli Sorry, I can't figure how to hide these arrows. There is not a setting called hidesExplorerArrows

[aeschli]

@equinusocio It's a new property for file icon themes. The built-in file icon themes aren't using it, but to try it out, add "hidesExplorerArrows":"true" to the top level of the minimal file icon theme

[equinusocio]

@aeschli Thank you. I tried on my icon theme but it doesn't work.

{
   "hidesExplorerArrows": "true",
   "iconDefinitions":{
      "_folder_dark":{
         "iconPath":"./icons/folder.svg"
      }
   },
   "fileExtensions":{
      "cmd":"_file_cmd",
      "mustache":"_file_mustache",
      "rails":"_file_rails"
   },
   "fileNames":{
      "gruntfile.js":"_file_grunt"
   },
   "file":"_file_dark",
   "folder":"_folder_dark",
   "folderExpanded":"_folder_open",
   "folderNames":{
      "node_modules":"_file_nodejs",
      ".git":"_file_git",
      ".github":"_file_github",
      ".gulp":"_file_gulp",
      "bower_components":"_file_bower"
   }
 
}

EDIT it worked with "hidesExplorerArrows": true

[equinusocio]

@aeschli Consider to use visibility: hidden instead of display: none to keep the same space for nested folders/files.

[tam5]

@aeschli @equinusocio I went back and forth on that as you can even see on the PR. Not sure there is a right or wrong answer, we'll just have to wait until more customization is available for the sidebar (i.e. padding) so everyone can decide for themselves.

[aeschli]

@equinusocio Sorry, I mistyped, it has to be "hidesExplorerArrows":true (no quotes around `true')

[aeschli]

To verify: Install an icon theme e.g. https://marketplace.visualstudio.com/items?itemName=gebilaoxiong.vscode-flatland-icon-theme. In the extensions folder find the extension and its icon theme file and add "hidesExplorerArrows":true

[equinusocio]

This works on Material Theme.