Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to install an SCM provider to the Switch SCM Provider menu #25696

Closed
egamma opened this issue Apr 30, 2017 · 13 comments
Closed

Add command to install an SCM provider to the Switch SCM Provider menu #25696

egamma opened this issue Apr 30, 2017 · 13 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality scm General SCM compound issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Apr 30, 2017

The Switch SCM Provider submenu (see below) should provide a Command to install SCM extensions, same as it is done for debuggers (Command Install Additional Debuggers) (see below below)

image

image

@egamma egamma added feature-request Request for new features or functionality scm General SCM compound issues labels Apr 30, 2017
@joaomoreno
Copy link
Member

We don't have a Marketplace query for SCM providers, since they don't have any declarative keys. We could create a Category for them and manually add extensions to that category.

cc @waderyan

@joaomoreno joaomoreno assigned waderyan and unassigned joaomoreno May 2, 2017
@joaomoreno joaomoreno added extensions Issues concerning extensions and removed scm General SCM compound issues labels May 2, 2017
@joaomoreno joaomoreno self-assigned this May 2, 2017
@joaomoreno joaomoreno added the scm General SCM compound issues label May 2, 2017
@joaomoreno joaomoreno added this to the Backlog milestone May 2, 2017
@waderyan
Copy link

waderyan commented May 2, 2017

FYI the category exists. The category is "SCM Providers" and will show up when we have at least one extension with that category.

joaomoreno added a commit to joaomoreno/vscode-perforce that referenced this issue May 4, 2017
VSCode could automatically drive users to discover new SCM Providers in the Marketplace. For this, we need the extensions to have the correct category.

Related to microsoft/vscode#25696
joaomoreno added a commit to joaomoreno/vsts-vscode that referenced this issue May 4, 2017
VSCode could automatically drive users to discover new SCM Providers in the Marketplace. For this, we need the extensions to have the correct category.

Related to microsoft/vscode#25696
@joaomoreno joaomoreno modified the milestones: May 2017, Backlog May 4, 2017
@joaomoreno
Copy link
Member

@waderyan Notice that @mrcrowl can't publish his extension with that category:

@joaomoreno vsce won't let me publish with that category:

C:\Users\mrcrowl\Documents\GitHub\vscode-hg-scm> vsce publish
Executing prepublish script 'npm run vscode:prepublish'...

> hg@1.0.4 vscode:prepublish C:\Users\mrcrowl\Documents\GitHub\vscode-hg-scm
> tsc -p ./

Publishing mrcrowl.hg@1.0.4...
Error: The category 'SCM Providers' is not available in language 'en-us'.

(vsce version 1.20.0)

Are you sure the Marketplace guys already enabled it?

stef-levesque pushed a commit to stef-levesque/vscode-perforce that referenced this issue May 4, 2017
VSCode could automatically drive users to discover new SCM Providers in the Marketplace. For this, we need the extensions to have the correct category.

Related to microsoft/vscode#25696
@stef-levesque
Copy link

I also get the following warning in in package.json
image

@stef-levesque
Copy link

stef-levesque commented May 4, 2017

extensionsRegistry.ts#L142

categories: {
	description: nls.localize('vscode.extension.categories', 'The categories used by the VS Code gallery to categorize the extension.'),
	type: 'array',
	uniqueItems: true,
	items: {
		type: 'string',
		enum: ['Languages', 'Snippets', 'Linters', 'Themes', 'Debuggers', 'Other', 'Keymaps', 'Formatters', 'Extension Packs']
	}
},

This should likely be updated.

@joaomoreno
Copy link
Member

joaomoreno commented May 4, 2017

Thanks @stef-levesque. Pushed a34e5de

@kieferrm kieferrm mentioned this issue May 5, 2017
44 tasks
@mrcrowl
Copy link

mrcrowl commented May 12, 2017

@joaomoreno, @stef-levesque This seems to be fixed now. I've just pushed Hg out using the SCM Providers category.

EDIT: package.json still gives me a warning about the category (this is std vs code, not insiders)

@jeffyoung
Copy link

Do we need any particular version of vsce to get this working? Our build machine currently has 1.15.0.

@mrcrowl
Copy link

mrcrowl commented May 15, 2017 via email

jeffyoung pushed a commit to microsoft/azure-repos-vscode that referenced this issue May 15, 2017
VSCode could automatically drive users to discover new SCM Providers in the Marketplace. For this, we need the extensions to have the correct category.

Related to microsoft/vscode#25696
@joaomoreno
Copy link
Member

@jeffyoung Yeah, you might wanna update it to the latest.

Thanks for the confirmation @mrcrowl.

@egamma egamma assigned isidorn and unassigned joaomoreno May 17, 2017
@isidorn isidorn added the verification-needed Verification of issue is requested label May 18, 2017
@isidorn
Copy link
Contributor

isidorn commented May 18, 2017

scmproviders

@joaomoreno
Copy link
Member

Awesome @isidorn 🍻

@bpasero bpasero added the verified Verification succeeded label May 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality scm General SCM compound issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants