Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt TS 2.4 For VS Code Build #28643

Closed
mjbvz opened this issue Jun 13, 2017 · 3 comments · Fixed by #30473
Closed

Adopt TS 2.4 For VS Code Build #28643

mjbvz opened this issue Jun 13, 2017 · 3 comments · Fixed by #30473
Assignees
@mjbvz
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
July 2017

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 13, 2017

Adopt TS 2.4 for building VS Code
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Jun 13, 2017
@mjbvz mjbvz added this to the June 2017 milestone Jun 13, 2017
@mjbvz mjbvz self-assigned this Jun 13, 2017
@kieferrm kieferrm mentioned this issue Jun 13, 2017
Closed
30 tasks
@mjbvz mjbvz modified the milestones: July 2017, June 2017 Jun 29, 2017
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 29, 2017

Given the number of breaking changes that landed late in the TS 2.4 cycle, adopting it is going to be a more involved than anticipated. Moving out to July as we need at least another month to work on picking it up

@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 30, 2017

Blocked by microsoft/TypeScript#16772 which is going into ts 2.4.2

@fasterthanlime fasterthanlime mentioned this issue Jul 1, 2017
Closed
@kieferrm kieferrm mentioned this issue Jul 6, 2017
Closed
39 tasks
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 6, 2017

Depends on jrieken/gulp-tsb#62

PR with fix: jrieken/gulp-tsb#63

@mjbvz mjbvz mentioned this issue Jul 12, 2017
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 12, 2017
@mjbvz
Build VSCode using TS 2.4.1
0d7701c 
Fixes microsoft#28643

a
mjbvz added a commit that referenced this issue Jul 12, 2017
@mjbvz
Build VSCode using TS 2.4 (#30473)
5da27ba 
* Build VSCode using TS 2.4.1

Fixes #28643

a

* Reformat a few files for 2.4

* Fix compile errors in jsoneditingservice
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
July 2017
Development

Successfully merging a pull request may close this issue.

Build VSCode using TS 2.4 mjbvz/vscode
1 participant
@mjbvz