Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with syntax highlighting (HTML/PHP) #34204

Closed
mattiamerlini opened this issue Sep 12, 2017 · 6 comments
Closed

Problem with syntax highlighting (HTML/PHP) #34204

mattiamerlini opened this issue Sep 12, 2017 · 6 comments
Assignees
@roblourens
Labels
candidate Issue identified as probable candidate for fixing in the next release php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August Recovery 2017

Comments

@mattiamerlini
Copy link

Problem with syntax highlighting as reported below:

image

  • VSCode Version: 1.16.0 (1.16.0)
  • OS Version: Mac OSX Sierra 10.12.5

Steps to Reproduce:

  1. Write HTML code
  2. Insert multiline pieces of PHP code
  3. See that the syntax doesn't recognise the open/close php tag
@vscodebot vscodebot bot added the php PHP support issues label Sep 12, 2017
@roblourens
Copy link
Member

Another instance of atom/language-php#246...

@roblourens roblourens added upstream Issue identified as 'upstream' component related (exists outside of VS Code) candidate Issue identified as probable candidate for fixing in the next release labels Sep 12, 2017
@roblourens roblourens added this to the August Recovery 2017 milestone Sep 12, 2017
This was referenced Sep 13, 2017
Closed
Closed
Closed
Closed
@roblourens
Copy link
Member

This will be fixed in tomorrow's Insiders build

This was referenced Sep 14, 2017
Closed
Closed
@weinand weinand added the verification-needed Verification of issue is requested label Sep 14, 2017
@maldetquest
Copy link

What about the regular build?

@roblourens
Copy link
Member

It will be in 1.16.1, whenever we get that out.

roblourens added a commit that referenced this issue Sep 14, 2017
@roblourens
Fix #34204 - revert problematic brace matching change from language-php
27492b6
@mjbvz mjbvz added the verified Verification succeeded label Sep 14, 2017
@daviddeejjames
Copy link

Thank youuuu @roblourens, this was released today in 1.16.1 😄

@khanhvu14
Copy link

good job, thank you :)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
candidate Issue identified as probable candidate for fixing in the next release php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August Recovery 2017
Development

No branches or pull requests
7 participants
@roblourens @weinand @khanhvu14 @daviddeejjames @mjbvz @mattiamerlini @maldetquest