Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide different settings for color picker and color preview (that square showing color) #34341

Closed
ajitid opened this issue Sep 14, 2017 · 10 comments
Assignees
Labels
editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality

Comments

@ajitid
Copy link
Contributor

ajitid commented Sep 14, 2017

Right now in settings there is only one setting to toggle both color picker and that square which is shown at the left of the color. I found vscode-colorize better, which shows color behind the text and is better than a square which pops up everytime when it identifies a color. The problem is that I still want to use that in-built color picker, but as they are toggled with same setting I'm unable to do so.

@aeschli
Copy link
Contributor

aeschli commented Sep 14, 2017

IMO colorDecorators should only affect the color boxes, but not the color picker.

@aeschli aeschli removed their assignment Sep 14, 2017
@alexdima alexdima added the editor-color-picker Editor color picker widget issues label Oct 26, 2017
@bpasero bpasero removed the workbench label Nov 16, 2017
@rebornix rebornix added the feature-request Request for new features or functionality label Nov 16, 2017
@ajitid ajitid changed the title Provide different settings for color picker and that square showing color Provide different settings for color picker and color preview (that square showing color) Jul 6, 2018
@justablob
Copy link

+1

@CodyWalraven
Copy link

I would really like this feature as well, when using other extensions to show the color behind the text I would still like to be able to have the color picker available while leaving the default color decorator box hidden.

@luck2011
Copy link

luck2011 commented Apr 12, 2019

Yes please stop changing the color text.
We are not designers.

@TargiX
Copy link

TargiX commented Apr 10, 2020

Guys, almost 3 years you can't separate those 2 features, what's going on? Please separate settings for disable color decorators and color picker. I believe that this is one day fix...

@joshuaptfan
Copy link

I would really like to be able to disable the color picker specifically.

Many times, while trying to select something else in CSS, I have accidentally moused over a color, then accidentally clicked in the color picker, and have to Ctrl+Z an unwanted color change that mangled my nice neat #F70 into rgb(158, 116, 79).

@rebornix rebornix added this to the Backlog milestone Oct 11, 2021
@rebornix rebornix removed their assignment Oct 11, 2021
@jzyrobert
Copy link
Contributor

jzyrobert commented Nov 13, 2021

@rebornix This doesn't have the "help wanted" label but would you accept a PR?

I'd like this feature and here is the branch in my fork that enables it.

@vintprox
Copy link

vintprox commented Mar 30, 2022

Just informing that this feature is pretty relevant, so @jzyrobert volunteered and made fork just for that. Color picker and decorator should not have been coupled in the first place.

@Drumstix42
Copy link

This would be a welcome feature split. I too use the Colorize extension, and would like to disable only the color square prefix, but retain the color picker hover feature.

@aiday-mar
Copy link
Contributor

Hi thank you all for the feedback. Earlier this year we have added the command Show or Focus Standalone Color Picker which allows one to spawn the color picker anywhere in the file. From what I understood, the other request here is to disable the color decorators from spawning a color picker on interation with it? There is the new setting editor.colorDecoratorsActivatedOn which allows one to control under what circumstances the color picker is spawned. It takes as values click, hover or clickAndHover. You can use these two features in conjunction in order to control the behavior of the color picker.

This issue will be closed in the meantime. If you have more feature requests or see bugs, feel free to open a new issue in the repo.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@aiday-mar aiday-mar removed this from the Backlog milestone Feb 6, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests