Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't disable color picker when editor.colorDecorators is false #52696

Closed
iansan5653 opened this issue Jun 22, 2018 · 4 comments
Closed

Don't disable color picker when editor.colorDecorators is false #52696

iansan5653 opened this issue Jun 22, 2018 · 4 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality
Milestone

Comments

@iansan5653
Copy link
Contributor

When editor.colorDecorators is set to false, the color picker UI no longer appears on hover. This is the intended behavior as per the setting documentation, however it doesn't make much sense this way. There is a strong motivation for disabling the inline color decorators, since they break vertical/column text selection, but the color decorators themselves are not necessary for the color picker UI to show, since it shows when hovering over the colors themselves, not the decorators.

For example, I just installed the "Color Higlight" extension so that I wouldn't need the decorators, since they mess with vertical text selection. I then disabled editor.colorDecorators so just the highlights appear. Now, I can't use the built in color picker, which is somewhat frustrating. I have to choose between having the color picker or not having my vertical selection broken.

@vscodebot vscodebot bot added editor editor-color-picker Editor color picker widget issues labels Jun 22, 2018
@alexdima alexdima added this to the On Deck milestone Jul 27, 2018
@niderhoff
Copy link

Duplicate of #34341 ?

@rebornix rebornix added feature-request Request for new features or functionality *duplicate Issue identified as a duplicate of another issue(s) labels Sep 5, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 5, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 5, 2018
@rebornix
Copy link
Member

rebornix commented Sep 5, 2018

Thanks, let's track it in #34341

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants