Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vim Extension Fails to Load on Extension Update #40260

Closed
jpoon opened this issue Dec 15, 2017 · 13 comments
Closed

Vim Extension Fails to Load on Extension Update #40260

jpoon opened this issue Dec 15, 2017 · 13 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone
January 2018

Comments

@jpoon
Copy link

jpoon commented Dec 15, 2017

  • VSCode Version: 1.19.0
  • OS Version: n/a -- various

Everytime we [VSCodeVim] push an update, we always seem to see cases where the extension fails to load. The recommendation I've been giving folks is to delete ~/.vscode/extensions/vscodevim and reinstall.

Reference: VSCodeVim/Vim#2226, VSCodeVim/Vim#2227, VSCodeVim/Vim#2185
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Dec 15, 2017
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Dec 15, 2017
@sandy081 sandy081 added this to the December 2017/January 2018 milestone Dec 15, 2017
@jpoon
Copy link
Author

jpoon commented Dec 16, 2017

Another one: VSCodeVim/Vim#2231

@jpoon jpoon closed this as completed Dec 16, 2017
@jpoon jpoon reopened this Dec 16, 2017
@jpoon
Copy link
Author

jpoon commented Dec 16, 2017

Oops, meant to just comment.

@diminutivesloop
Copy link
Contributor

You can also uninstall and then reinstall the extension via the command code --install-extension vscodevim.vim. That fixed the issue for me without having to delete all my other extensions.

@jpoon
Copy link
Author

jpoon commented Jan 4, 2018

Optimally, users shouldn't need to do that.

@peterjuras peterjuras mentioned this issue Jan 16, 2018
Closed
@jpoon
Copy link
Author

jpoon commented Jan 16, 2018

We pushed an update to the extension and got more reports of the upgrade breaking: #2287. Reinstalling the extension resolves the issue.

Is this just effecting VSCodeVim? Or are other extensions having issues when users are updating?

@sandy081
Copy link
Member

@jpoon Can you please give us more specific details about what is not working? And also are there any consistent steps to reproduce this which will be helpful?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jan 17, 2018
@jpoon
Copy link
Author

jpoon commented Jan 17, 2018 •
edited
Loading

@sandy081 Whenever we push an update to vscodevim, we often get issues stating that the new extension fails to load. We've seen this issue since likely the beginning of extension, but I've linked a few of the issues of people having failed to upgrade from 0.10.4->0.10.5, 0.10.5->0.10.6, 0.10.8->0.10.9, 0.10.9->0.10.10. The general symptom is the extension fails to load. The call stack in here: VSCodeVim/Vim#2185, might be helpful.

@sandy081
Copy link
Member

@jpoon From the stack trace it looks like the extension was not completely downloaded. Can you please ask users if this is the case?

@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Jan 19, 2018
@sandy081
Copy link
Member

After investigating more, I figured out that root cause is Auto update feature triggers updating the extension from all open windows and we try to install (download, delete existing and extract) the extension multiple times.

This can lead to different failures like

  • errors while deleting the existing folder
  • partially extracted extensions
  • error while accessing the extracted folder

ColCh added a commit to ColCh/vscode that referenced this issue Jan 20, 2018
@ColCh
Merge branch 'master' into 10413-fill-quick-open-with-selection
e660792 
* master: (280 commits)
  fix issue with useAltAsMultiSelectModifier
  Log ripgrep cmd from quickopen to logservice
  Switch search output panel to logservice
  Use absolute paths for webview core resources
  Explicitly hide TS version status when in ts/js file with unknown scheme
  First attempt of search caching.
  Pick up latest TS insiders
  2018-01-19. Merged in translations from Transifex.
  Avoid double-counting same settings search query
  Use latest emmet helper that has fixes microsoft#33818
  Remove settings search @groupId filters - since group ids can now be extension guids, and nobody uses this anyway
  backups - make sure to use "utf8" as encoding and not "utf-8"
  Catch any errors that onLineData users throw
  use uuid as extensions configuration id
  fix format on save problem that occurs when a provider returns no edits
  fix microsoft#41724
  Fix microsoft#41868
  some menu polish for issue reporter
  Fix microsoft#40260
  Simplify edits handling in TextModelTokens
  ...
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

Validated by:

  • create a new extension, install new extension
  • disable auto update
  • open 3 vscode windows
  • publish new version
  • in each window search for the extension
  • enable auto update, observe that all windows have updated the extension
  • verify that the extension still works

@aeschli aeschli added the verified Verification succeeded label Feb 1, 2018
@jpoon
Copy link
Author

jpoon commented Feb 1, 2018

Thanks @sandy081 and @aeschli :)

This was referenced Mar 2, 2018
Closed
Closed
@jpoon
Copy link
Author

jpoon commented Mar 5, 2018

We received a couple more reports of this happening for users updating to the latest version of VSCodeVim. The theme so far has been users have been all on Windows -- linked two issues above.

@jpoon
Copy link
Author

jpoon commented Mar 5, 2018

@sandy081 another reported case, also on windows: VSCodeVim/Vim#2420

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@jpoon @diminutivesloop @aeschli @sandy081