Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS X: "Open in Terminal" doesn't work for me #4298

Closed
weinand opened this issue Mar 16, 2016 · 4 comments
Closed

OS X: "Open in Terminal" doesn't work for me #4298

weinand opened this issue Mar 16, 2016 · 4 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
March 2016

Comments

@weinand
Copy link
Contributor

weinand commented Mar 16, 2016

  • VSCode 0.10.12-alpha
  • OO X 10.11.3
  • in the VS Code explorer run the "Open in Terminal" action

Observe: nothing happens
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Mar 16, 2016
@weinand weinand self-assigned this Mar 16, 2016
@weinand weinand added this to the March 2016 milestone Mar 16, 2016
@jbeckton
Copy link

Same issue on Linux as well. "Open new Terminal" does not work either

@weinand
Copy link
Contributor Author

weinand commented Mar 18, 2016

New versions of iTerm have changed the AppleScript API which broke the VSCode iTerm scripts. I made VS Code smarter in detecting what version of iTerm is installed and call either the old iterm or a new itermNew script.

weinand added a commit that referenced this issue Mar 18, 2016
@weinand
fix iTerm support for stable version of iTerm; another fix for #4298
1912d41
@pflannery
Copy link

@joaomoreno
this PR #3495 resolves the Linux issue where x-terminal-emulator isn't available.
Fedora 23 is an example where this problem is happening. Using this PR and changing the command to gnome-terminal works.

@weinand weinand assigned bpasero and unassigned weinand Mar 21, 2016
@bpasero
Copy link
Member

bpasero commented Mar 21, 2016

Verified that "Open in Terminal" works for me and opens my terminal. @weinand note that I do not have iTerm installed so you might want to assign this one to someone else?

@bpasero bpasero added the verified Verification succeeded label Mar 21, 2016
@weinand weinand removed the verified Verification succeeded label Mar 21, 2016
@weinand weinand assigned jrieken and unassigned bpasero Mar 21, 2016
@jrieken jrieken added the verified Verification succeeded label Mar 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
5 participants
@bpasero @pflannery @jrieken @weinand @jbeckton