Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing FS events #44036

Closed
joaomoreno opened this issue Feb 20, 2018 · 11 comments
Closed

Missing FS events #44036

joaomoreno opened this issue Feb 20, 2018 · 11 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug file-watcher File watcher important Issue identified as high-priority verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone
February 2018

Comments

@joaomoreno
Copy link
Member

Seen on macOS

  1. Open a new window
  2. Open folder A on that window
  3. Add folder B to that workspace
  4. Cause file events on folder B

The explorer doesn't update, git doesn't refresh, etc.
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug file-watcher File watcher labels Feb 20, 2018
@joaomoreno joaomoreno added this to the February 2018 milestone Feb 20, 2018
@Tyriar Tyriar mentioned this issue Feb 20, 2018
Closed
@Tyriar
Copy link
Member

Tyriar commented Feb 20, 2018

This was also reported at #44034, did something change with the file watcher recently?

@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2018

@Tyriar my issue is older 44034 < 44036. Just for future

@bpasero bpasero assigned Tyriar and unassigned bpasero Feb 20, 2018
@bpasero
Copy link
Member

bpasero commented Feb 20, 2018

@Tyriar let me know if you don't have time for February and I will take over.

@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Feb 20, 2018
@bpasero bpasero assigned bpasero and unassigned Tyriar Feb 20, 2018
@bpasero
Copy link
Member

bpasero commented Feb 20, 2018

Wait...

@bpasero
Copy link
Member

bpasero commented Feb 20, 2018

@joaomoreno wow crazy bug and simple fix, this has been in for 3 months, thanks for pushing on it ❤️

@bpasero bpasero closed this as completed Feb 20, 2018
bpasero added a commit that referenced this issue Feb 20, 2018
@bpasero
Missing FS events (fixes #44036)
a21640e
@bpasero bpasero added the important Issue identified as high-priority label Feb 20, 2018
@joaomoreno joaomoreno mentioned this issue Feb 20, 2018
Closed
@joaomoreno
Copy link
Member Author

Wow. Thanks for fixing!

@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2018

@bpasero thanks for givin joao a ❤️ and nothing for me

@joaomoreno
Copy link
Member Author

@isidorn You gotta push it!

@bpasero
Copy link
Member

bpasero commented Feb 20, 2018

@isidorn sorry bro, didn't see your other issue until now. 🍻 from me for both of you (and ❤️ )

@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2018

@bpasero I was kidding, though I still take that beer :)

@Tyriar
Copy link
Member

Tyriar commented Feb 20, 2018

Thanks for the fix @bpasero 😄

@joaomoreno joaomoreno mentioned this issue Feb 23, 2018
Closed
@joaomoreno joaomoreno added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug file-watcher File watcher important Issue identified as high-priority verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
5 participants
@joaomoreno @bpasero @isidorn @Tyriar and others