Integrated terminal does not line wrap when prompt string contains emojis

[martypdx]

This started with latest release

• VSCode Version: Version 1.20.1 (1.20.1)
• OS Version: OSX 10.13.3 (17D47)

Steps to Reproduce:

1. Open integrated terminal
2. Type text past the end of line and it wraps to same line.

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Expand line selection does not select all of wrapped line (#21450)

[Tyriar]

@martypdx can you share your $PS1 variable? Run echo $PS1 in the terminal to get it

[martypdx]

@Tyriar:

📂 rehype-add-classes 🚀 echo $PS1
📂 \W 🚀

[martypdx]

It's the pictorial unicode 📂 🚀

[Tyriar]

@martypdx does this happen in an external terminal when the width is set the same? It looks like all the terminal is doing here is following instructions from bash, and bash is not saying to go the next line.

[martypdx]

@Tyriar works fine in external terminal. Worked in prior release of VSCode.

[Tyriar]

@martypdx hmm, maybe the shell thinks it's wider than the terminal for some reason then? If you keep typing will it eventually wrap?

Also you could try test it in Insiders as a lot has changed with regards to layout in the terminal since 1.20 due to the introduction of splitting. https://code.visualstudio.com/insiders/

[martypdx]

@Tyriar:

If you keep typing will it eventually wrap?

Yes, the second time around it wraps and subsequent lines wrap correct.

could try test it in Insiders

Problem still exists in Insiders :(

maybe the shell thinks it's wider than the terminal

But it only happens with certain characters in $PS1. Perhaps it's checking for certain character ranges and it needs to be broadened?

[Tyriar]

I now there's an issue with emojis right now if you add one to the prompt and delete it, this could be related to that?

[martypdx]

@Tyriar Yeah, looks like if you paste an emoji and then hit backspace/delete it removes two characters. I have seen other off-by-one behavior like this as well.

[Tyriar]

This is a bug in https://github.com/xtermjs/xterm.js, I don't think there's a tracking issue currently.

[Tyriar]

The original report where there is an issue with wrapping I believe is a problem with bash. For backspace this is tracked in xtermjs/xterm.js#1059