-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with emojis/unicode (assumed double-width?) #1059
Comments
I can't reproduce this on macOS/bash. I wouldn't expect it to happen unless we tried to tweak with the emoji width (make it non-1). Any more details on repro steps would be useful. |
Reproduce (OSX, MacOS High Sierra)
Are you already on MacOS High Sierra, because I am? Maybe it is also related to node-pty - I can see that when inserting an emoji in |
This might be a high sierra thing where they tried to make Emojis better in the terminal? I can't update currently as it messes up rendering in Electron apps. |
I hate to say that I've upgraded and now I'm stuck with tons of rendering glitches in all those chromium based apps 😤 |
Yeah I was careful to track feedback before updating as similar things happened with Sierra I think. |
I notice that Terminal.app has a nice emoji experience where they're treated as proper wide characters, we can probably do it if they can 😄 |
UAX #11 East Asian Width, Revision 31 changed emoji East Asian Wide (double-width), and |
@mandel59 thanks for the info! |
Reference: https://github.com/gnachman/iTerm2/blob/master/sources/NSCharacterSet+iTerm.m has some mapping solutions too. |
VS Code issue: microsoft/vscode#59145 Apparently flutter run demonstrates this behavior |
Here's a small Dart repro for what we're seeing that doesn't require Flutter (does require Dart though):
Save as a If I you remove the |
Also applies to Hebrew/Arabic as mentioned in microsoft/vscode#60470 |
First things first, I wanted to thank you guys for your amazing work. VSCode 1.31.1 on macOS Mojave 10.14.3 experiences the same. The |
I have the same bug as mentioned by @juliusecker. |
Turns out VSCode has some rendering issues in their integrated terminal, where emojis eat their next neighboring character. Let's not compensate for other peoples bugs and just wait for a fix. It's in the works I've heard. xtermjs/xterm.js#1059
Very simple to reproduce in VSCode and Powershell. emojiterminaltest.ps1"Emoji Normal"
"😊1😊2😊3😊4"
"Emoji with Padding Spaces - What it should look like"
"😊 1😊 2😊 3😊 4" Are there any resources assigned to this item? Looks like lots of regressions in other programs (Hyper, etc.) as seen on this issue thread. |
@Tyriar Yes kinda, its just an example where ppl most likely will face it - emojis 😸 |
I guess we'll keep them both opened as this describes the problem well and #1709 looks more at the solution, plus this one has a bunch of upvotes. |
Issue has been around nearly two years, any update? |
@jerch wants to get to it soon, he has a bunch of stuff ongoing atm though. One of the big blockers for this was the new addon system which is now released. |
Closing in favor of #1709 as they're essentially the same thing and we want to keep our issue count down. |
In current v3, Emojis seem to take up two cells. Using the arrow keys, two cells are jumped instead of one. Deleting also clears two cells.
The text was updated successfully, but these errors were encountered: