Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emojis using zero-width joiners shown as multiple emojis #2625

Closed
2 tasks done
16patsle opened this issue Jan 21, 2018 · 8 comments
Closed
2 tasks done

Emojis using zero-width joiners shown as multiple emojis #2625

16patsle opened this issue Jan 21, 2018 · 8 comments
Labels
help wanted Contributions wanted towards the issue 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself

Comments

@16patsle
Copy link

16patsle commented Jan 21, 2018 •
edited
Loading

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS 10.13.2

  • Hyper.app version: 1.4.8 and 2.0.0-canary.10

  • Link of a Gist with the contents of your .hyper.js: https://gist.github.com/16patsle/91998bf232afdc19b491be6dd07e1c6d

  • Relevant information from devtools: N/A

  • The issue is reproducible in vanilla Hyper.app: Yes, both stable and canary

Issue

Using emoji characters that consist of several characters combined with zero-width joiners does not work. The emoji it consists of is shown instead.

I'm using emojis in my bash prompt, and this was how I discovered the issue.
In the image below: how this should look (at the top, in iTerm) versus how it looks in Hyper (bottom)
hyper-emoji

This screenshot is using canary (2.0.0-canary.10). When using stable (1.4.8), only the first of the three show up.
@albinekb albinekb added the help wanted Contributions wanted towards the issue label Jan 23, 2018
@Stanzilla
Copy link
Collaborator

Hey @16patsle could you do us a favor and test that in another terminal that uses xterm.js? The Visual Studio Code terminal is one of those. If you find that the issue exists there as well, please open an issue at https://github.com/xtermjs/xterm.js/ and/or take a look if xtermjs/xterm.js#1059 already is what you are seeing.

@Stanzilla Stanzilla added the 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself label Apr 23, 2018
@16patsle
Copy link
Author

16patsle commented Apr 25, 2018 •
edited
Loading

Problem exists in the integrated terminal in VS Code too. After searching a bit, I found that this issue seems to be for the same problem:
xtermjs/xterm.js#942

Doesn't seem like it's solved yet, so in the mean time I'm going back to a more boring bash prompt.

@decembre
Copy link

decembre commented Sep 1, 2019 •
edited
Loading

On firefoxv56.2.13 / Win 10.
from:

Work:
🏳️‍🌈 Rainbow Flag

  • Don't work:
    🏴‍☠️ Pirate Flag
    ◯‍◯‍◯‍◯‍◯ Olympic Rings
    🤼🏿‍♀️ Women Wrestling, Type-6
    👯🏻‍♀️ Women With Bunny Ears Partying, Type-1-2

@Stanzilla
Copy link
Collaborator

Can you try with a CI build of current canary or maybe compile one yourself?

@16patsle
Copy link
Author

@Stanzilla Tried with canary build 2472 from CircleCI, and it still shows as multiple emojis
Skjermbilde 2019-10-13 kl 13 11 17

@Stanzilla
Copy link
Collaborator

@Tyriar should this work with xterm 4.1 in the canvas renderer?

@Tyriar
Copy link
Contributor

Tyriar commented Oct 14, 2019

I think this is xtermjs/xterm.js#942

@ortonomy
Copy link

! why was this closed.. still a problem today.

iTerm:
image

hyper:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contributions wanted towards the issue 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Stanzilla @decembre @Tyriar @albinekb @ortonomy @16patsle