Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support triggering rename on import path in js/ts #51175

Closed
mjbvz opened this issue Jun 5, 2018 · 6 comments
Closed

Support triggering rename on import path in js/ts #51175

mjbvz opened this issue Jun 5, 2018 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 5, 2018

Feature
Support hitting f2 on an import path to rename a file and references to it

Depends on microsoft/TypeScript#24702 microsoft/TypeScript#24501

@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues javascript JavaScript support issues labels Jun 5, 2018
@mjbvz mjbvz added this to the June 2018 milestone Jun 5, 2018
@mjbvz mjbvz self-assigned this Jun 5, 2018
@mjbvz mjbvz modified the milestones: June 2018, July 2018 Jun 13, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 13, 2018
@mjbvz mjbvz modified the milestones: July 2018, On Deck Jul 19, 2018
@mjbvz mjbvz modified the milestones: On Deck, September 2018 Sep 7, 2018
@mjbvz mjbvz closed this as completed in 1be59b4 Sep 18, 2018
@mjbvz mjbvz mentioned this issue Sep 19, 2018
4 tasks
@bpasero
Copy link
Member

bpasero commented Sep 26, 2018

@mjbvz verification needed?

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 26, 2018
@miguelsolorio miguelsolorio added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Sep 26, 2018
@octref octref removed the verified Verification succeeded label Sep 26, 2018
@octref
Copy link
Contributor

octref commented Sep 26, 2018

I suggest that we move this one out of September, there are a lot of bugs in my testing:

  • For './foo/bar', the rename only triggers on each segment like foo or bar, but not all of them
  • Triggering rename on either foo or bar replaces the whole import path
  • When importing a js file from another js file, it doesn't seem to work. I cannot rename on the import path.
  • When importing a js file from another ts file, I get this error when trying to rename: A system error occurred (ENOENT: no such file or directory, rename '/Users/octref/Code/repro/foo/bar.ts' -> '/Users/octref/Code/repro/foo/baz.js.ts')

tsbug

@octref octref reopened this Sep 26, 2018
@octref octref added the verification-needed Verification of issue is requested label Sep 26, 2018
@octref
Copy link
Contributor

octref commented Sep 26, 2018

Additionally, in each of my attempt, the rename removes the file extension.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 26, 2018

There's too many bugs upstream with this. Moving to next month

See: microsoft/TypeScript#27377

@mjbvz mjbvz modified the milestones: September 2018, October 2018 Sep 26, 2018
@mjbvz mjbvz removed the verification-needed Verification of issue is requested label Sep 26, 2018
mjbvz added a commit that referenced this issue Sep 26, 2018
Outcome of #51175. Requires fixes upstream
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 27, 2018
@mjbvz mjbvz removed this from the October 2018 milestone Sep 27, 2018
@mjbvz mjbvz added this to the September 2018 milestone Sep 27, 2018
@mjbvz mjbvz closed this as completed in a2d3c87 Sep 27, 2018
mjbvz added a commit that referenced this issue Sep 27, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented Sep 27, 2018

Nevermind! Was holding the api wrong :)

Should work in next insiders build

@sbatten sbatten added the verified Verification succeeded label Sep 28, 2018
@sbatten
Copy link
Member

sbatten commented Sep 28, 2018

hit what looks like this issue microsoft/TypeScript#27373 while testing in vscode repo on non-relative paths

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants