Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings editor: provide context menu actions #54140

Closed
joaomoreno opened this issue Jul 12, 2018 · 6 comments
Closed

Settings editor: provide context menu actions #54140

joaomoreno opened this issue Jul 12, 2018 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan settings-editor VS Code settings editor issues
Milestone

Comments

@joaomoreno
Copy link
Member

It would be great to have a few context menu actions on the settings editor:

  • Copy setting to clipboard (including key and value)
  • Set to default
@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Jul 12, 2018
@roblourens roblourens added this to the July 2018 milestone Jul 12, 2018
@roblourens roblourens modified the milestones: July 2018, August 2018 Aug 2, 2018
@roblourens roblourens mentioned this issue Aug 3, 2018
38 tasks
@roblourens
Copy link
Member

Here is Miguel's mockup for where a context menu action might go:

gif

@miguelsolorio
Copy link
Contributor

Here's a bigger version:

image

@roblourens
Copy link
Member

I like this, but I'm also kind of inclined to put it in a consistent spot for every setting (regardless of how wide the control is). Other options I can think of are

  • Below the control - but then it looks like the old expansion indicator
  • Next to the label - but there's already a lot going on, in that row
  • Right justified - but nothing in the setting is right-justified
  • Left of the control - but a '...' looks wrong to the left of something, it should to the right. ("There is more...")

The right-justified option makes me think of Slack

image

They also have it on the right, when nothing else is right-justified. They also show that subtle hover color to tie it together.

@miguelsolorio
Copy link
Contributor

Yea, I agree with your points.

One idea (not sure how I feel about it) is to move it to the left as it's the only consistent place it can go, and maybe use an alternative icon (unsure of what that could be).

image

image

@roblourens
Copy link
Member

I like that but I think that we should stick with ... for a dropdown. It might not be that bad on the left though.

@roblourens
Copy link
Member

Had to use shift+f9 for the keyboard shortcut because shift+f10 still needs to show the context menu for input elements.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

3 participants