Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command to enter a workspace without window reload #54335

Closed
bpasero opened this issue Jul 15, 2018 · 4 comments · Fixed by #54129
Closed

Add a command to enter a workspace without window reload #54335

bpasero opened this issue Jul 15, 2018 · 4 comments · Fixed by #54129
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jul 15, 2018

This will help extensions like LiveShare that create ad-hoc workspaces to perform the switch from empty window to workspace without a window reload much faster.

Verify:

  • write an extension (hello world is fine)
  • craft any workspace file on disk
  • add code like this: vscode.commands.executeCommand('_workbench.enterWorkspace', vscode.Uri.file('<path to workspace file'));
  • you should enter this workspace without a window reload
@bpasero bpasero added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Jul 15, 2018
@bpasero bpasero added this to the July 2018 milestone Jul 15, 2018
@bpasero bpasero self-assigned this Jul 15, 2018
@bpasero bpasero closed this as completed Jul 15, 2018
@isidorn isidorn added the verified Verification succeeded label Jul 31, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 31, 2018

The new workspace seems to be opened without a reload, however the extension host is not started properly.
Follow your steps from above and wait 10 seconds and get an error -> reopening and assigning to August

screen shot 2018-07-31 at 15 47 31

@isidorn isidorn reopened this Jul 31, 2018
@isidorn isidorn modified the milestones: July 2018, August 2018 Jul 31, 2018
@isidorn isidorn added the verification-found Issue verification failed label Jul 31, 2018
@bpasero bpasero removed verification-found Issue verification failed verified Verification succeeded labels Aug 6, 2018
@bpasero
Copy link
Member Author

bpasero commented Aug 6, 2018

I know this used to work when I tested, so I speculate @sandy081 your changes might have caused this maybe after my changes were pushed?

@bpasero
Copy link
Member Author

bpasero commented Aug 8, 2018

Very likely same symptoms as #55025, I see the extension host restarts but it is stopped in debug break.

@bpasero bpasero closed this as completed Aug 8, 2018
@bpasero bpasero modified the milestones: August 2018, July 2018 Aug 8, 2018
@weinand weinand added the verified Verification succeeded label Aug 9, 2018
@weinand
Copy link
Contributor

weinand commented Aug 9, 2018

Verified on macOS, Windows, and linux.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants