add _workbench.enterWorkspace #54129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
approved these changes
Jul 13, 2018
| @@ -144,6 +144,10 @@ export class WorkspaceEditingService implements IWorkspaceEditingService { | |||
| return false; | |||
| } | |||
|
|
|||
| enterWorkspace(path: string): TPromise<void> { | |||
There was a problem hiding this comment.
May be we should move entering workspace API to IWorkspaceContextService? Because I think having these APIs in IWorkspaceEditingService does not fit good to me.
If agreed, I will tackle it in the next debt week
There was a problem hiding this comment.
@sandy081 yeah, but there are more methods like createAndEnterWorkspace and saveAndEnterWorkspace which then should also move. I am all up for not having that in the editing service if possible.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #35109 (but not a full fix for it). Fixes #54335
This enables LiveShare to enter a workspace without window reload:
This is not a general mechanism for switching without window reload, it only works best if the target workspace was never opened before, because:
As a result of calling this command, the extension host will still restart.
/cc @egamma