-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DocumentSymbol.selectionRange doesn't seem to work #54857
Comments
Yeah, we didn't adopt that for quick outline (yet) but only for the outline tree and the breadcrumbs |
Pushed a fix to use the |
Nevermind - pushed another change so that the |
Thanks! I'll check it out in the next Insider's build that includes the changes. |
Thanks, now it's working as I'd expect. 👍 One question: should doc comments before fields / types be included in |
Yeah, I'd also say yes. |
E.g. enum constructors, simple typedef fields... The difference is only visible with VSCode 1.26, see microsoft/vscode#54857.
Disabled for now until VSCode 1.26 is out because of microsoft/vscode#54857 (otherwise selecting something would select the start of the doc comment instead of the symbol).
@jrieken What is the desired behavior here? Not seeing any difference between range and selection range. In particular, not seeing the "yellow highlight". |
To verify
|
The docs for
DocumentSymbol.selectionRange
state:To me, this implies that picking a symbol from Ctrl+Shift+O selects this range (not sure what else it would be for, selecting something in the Outline view doesn't set a cursor selection / only navigates to the line).
Instead, the cursor is positioned at the start of
range
(in this example, theselectionRange
coversname
).I would expect the cursor to be positioned before
name
, and perhaps also select it. Originally brought this up in microsoft/vscode-languageserver-node#373 (comment).The text was updated successfully, but these errors were encountered: