Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeybindingService is many services #5614

Closed
jrieken opened this issue Apr 21, 2016 · 2 comments · Fixed by #10480
Closed

KeybindingService is many services #5614

jrieken opened this issue Apr 21, 2016 · 2 comments · Fixed by #10480
Assignees
@jrieken @alexdima
Labels
debt Code quality issues
Milestone
August 2016

Comments

@jrieken
Copy link
Member

jrieken commented Apr 21, 2016

The keybindings service is great but also a monster. It does multiple things and I wonder if we can break it up into the following:

  • a service that manages context key and its values
  • a service that manages and executes commands
  • a service that dispatches a key event to a command execution
@jrieken jrieken added the debt Code quality issues label Apr 21, 2016
@jrieken
Copy link
Member Author

jrieken commented Apr 21, 2016

related to #5505

@jrieken jrieken mentioned this issue Apr 28, 2016
Closed
@jrieken jrieken self-assigned this Jul 27, 2016
@jrieken
Copy link
Member Author

jrieken commented Jul 27, 2016

We pulled out the command registry and a command service. Progress at least 🏃

@alexdima alexdima mentioned this issue Aug 12, 2016
Merged
@alexdima alexdima added this to the August 2016 milestone Aug 12, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@alexdima alexdima

Labels
debt Code quality issues
Projects
None yet
Milestone
August 2016
Development

Successfully merging a pull request may close this issue.

Extract ContextKeyService from KeybindingsService microsoft/vscode
2 participants
@jrieken @alexdima