Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define what 'args' is in IKeybindingService#executeCommand #5934

Closed
jrieken opened this issue Apr 28, 2016 · 2 comments
Closed

define what 'args' is in IKeybindingService#executeCommand #5934

jrieken opened this issue Apr 28, 2016 · 2 comments
Assignees
@alexdima
Labels
debt Code quality issues
Milestone
March 2017

Comments

@jrieken
Copy link
Member

jrieken commented Apr 28, 2016

The keybinding services allows to manually invoke a command. The signature today is executeCommand(commandId: string, args?: any): TPromise<any>; but it is unclear what args is esp. w.r.t. multiple arguments and the type (there is some massaging going on).
@jrieken jrieken added the debt Code quality issues label Apr 28, 2016
@jrieken
Copy link
Member Author

jrieken commented Apr 28, 2016

related to #5902 and #5614

@alexdima alexdima added this to the March 2017 milestone Mar 2, 2017
@alexdima
Copy link
Member

obsolete I think

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
2 participants
@jrieken @alexdima