Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI lacks concept of inherited default value #57330

Open
jrieken opened this issue Aug 28, 2018 · 9 comments
Open

Settings UI lacks concept of inherited default value #57330

jrieken opened this issue Aug 28, 2018 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Aug 28, 2018

re #57304

  • open settings UI
  • locate 'Suggest Font Size'
  • notice how the UI shows 0 which isn't true - the default value is the font size of the editor.

screen shot 2018-08-28 at 09 47 01

@roblourens
Copy link
Member

0 means "the font size of the editor" but the value itself is 0. If we want to change that, the default could be null which would show in the UI as an empty input box. How would you display the real default?

image

@roblourens roblourens added the info-needed Issue requires more information from poster label Aug 28, 2018
@jrieken
Copy link
Member Author

jrieken commented Aug 29, 2018

Well, it should show 12 or whatever the editor font size is. The fact that we internally treat 0 as 'use editor font size' is an implementation that leaks into the UI. I think a user that didn't implement the suggest widget won't understand this

@jrieken jrieken removed the info-needed Issue requires more information from poster label Aug 29, 2018
@roblourens
Copy link
Member

roblourens commented Aug 29, 2018

Do you know of any other settings with similar behavior that fall back on the value of another setting? Would need some metadata or something for this.

@roblourens roblourens added settings-editor VS Code settings editor issues under-discussion Issue is under discussion for relevance, priority, approach labels Aug 29, 2018
@jrieken
Copy link
Member Author

jrieken commented Aug 30, 2018

Yeah, metadata is needed. When defining a setting we should be able to refer to another setting which defines its default

@chrmarti
Copy link
Collaborator

Or just add (0 to use the editor's font size) to the description.

@roblourens roblourens added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 5, 2018
@roblourens
Copy link
Member

I added a note to the descriptions for those two settings.

@rzhao271
Copy link
Contributor

rzhao271 commented Mar 3, 2022

We currently have the ability for extensions to override the default value of other settings with contributes.configurationDefaults.
This feature sounds like we want settings to "look to" other settings for the default value.

#57330 (comment) is nice, because we avoid having to change the setting to use nullable types.

Moving this to backlog candidates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @jrieken @rzhao271 @chrmarti and others