-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings UI lacks concept of inherited default value #57330
Comments
Well, it should show 12 or whatever the editor font size is. The fact that we internally treat 0 as 'use editor font size' is an implementation that leaks into the UI. I think a user that didn't implement the suggest widget won't understand this |
Do you know of any other settings with similar behavior that fall back on the value of another setting? Would need some metadata or something for this. |
Yeah, metadata is needed. When defining a setting we should be able to refer to another setting which defines its default |
Or just add |
I added a note to the descriptions for those two settings. |
We currently have the ability for extensions to override the default value of other settings with #57330 (comment) is nice, because we avoid having to change the setting to use nullable types. Moving this to backlog candidates. |
re #57304
0
which isn't true - the default value is the font size of the editor.The text was updated successfully, but these errors were encountered: