Settings: icon in suggest box does not seem useful #57380
Assignees
Labels
bug
Issue identified by VS Code Team member as probable bug
settings-editor
VS Code settings editor issues
verified
Verification succeeded
Milestone
Comments
|
I wonder if there would ever be a case where an icon would be useful in this context? I could see how having an icon for each category would be useful, but repeating the icon feels unnecessary. This also applies to the extension search. |
|
Let's just remove the icon now and we can add them once we have categories (if that ever happens) |
|
Is it possible to remove it? I think all suggest widget items need an icon |
|
If not then I guess this would be a feature request against the suggest widget @ramya-rao-a |
roblourens
added
settings-editor
|
All suggestion items are required to have a type which is an enum and the icons are derived from the types. @jrieken Thoughts? |
|
👎 for type |
|
I see that setting, it applies to the editor instance so it should be usable here. It just looks like I have to add a CSS rule for the |
roblourens
added
bug
|
@jrieken That setting is not exposed to the user. And the suggest widget doesnt really respect it. It adds the Was this is a old feature that got missed along the way? |
|
Yeah, maybe. @joaomoreno would know |
|
|
|
Added a new rule just for SuggestEnabledInput. Maybe we should just have a rule for all suggest widgets, but I see the outline panel is using the same class and I'm not sure what else it would disturb? Looks nicer though
|
|
@roblourens The outline panel does not use the suggest widget, so I dont know how the 2 are related. I would suggest to add the css rule in https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/suggest/media/suggest.css#L145 |
|
Oh, right. But still I don't know what monaco users are expecting or why the rule doesn't exist, so I'm not just going to add a new css rule for every suggest widget. |
ramya-rao-a
added a commit
that referenced
this issue
Sep 26, 2018
GongT
pushed a commit
to kendryte/kendryte-ide
that referenced
this issue
Oct 18, 2018
994eaadcb9 Move icon theme down to editor/platform. Fixes #61031
faf868edf4 propagate error when it happens very early, make sure to throw meaningful error on ext host side, #61182
0ca196a5cd Save file dialog initialized with the filesystem root. Fixes #60939
a333fd01bb Empty window with backup: opens twice the same window on each restart. Fixes #61210
a6c8d961d4 debug: make sure to de-dupe if a session is re-intialized. In case of EH debugging we are adding a session again after an attach.
2f78e29ce5 Fixing image viewer zoom (#61198)
9e83209ed5 Bump node2
0120caf4e3 Fix querybuilder tests
66d113d2ce Fix #61089 - setting row height
d47f6b4f99 Fix #61041
9b739ad670 Refactor search - multiline/preview options tweaks
1b812bade4 Don't re-encode markdown styles http uris
481e001d0b Strict null checks
33d86f14e2 Auto add a few more files to strict null checks
c6f19c3ceb Use theme colors for webview scrollbars
39b6d1aaf2 Add guards for webview deserialization possibly failing
3cf3e16284 Explicitly type simple array
202c2b697f let -> const
f6397266ab Use namespaces for converts
e377ec6ed2 Use `to` for converting to extension host
b43d76887d Add more detail to `disableAutomaticTypeAcquisition` setting description
ff13b50277 Strict null checking some more files in base/node
0338b5b8fe Fixed typos and a word (#61171)
f891d5a7b0 include priority in requestItem and add to request queue accordingly (#60582)
4b8f928808 Faster monaco.d.ts generation
613aa464ae support relative paths for backward compatibility; fixes #61088
4f09f1aa4a Cache TS source files between runs of generator
238440b738 Change how monaco.d.ts is generated: - do not use the .d.ts files coming in from gulp-tsb - remove the generation of .d.ts files - run before compilation starts - install file watchers directly
48adb204e9 never convert relative paths to URIs; fixes #60667
f0101b07d4 new monaco.d.ts
993787821f typos #57093
078b1415e4 add proposed api for CompletionItemInsertTextRule, #57093
349c18db22 add CompletionItemInsertTextRules on modes.ts so that we can have that in vscode.d.ts, #57093
cceb269135 remove unused noAutoAccept property, #57093
bc94252427 storage - :lipstick:
1a348aa9f9 clone DAP message before modifying it; fixes #61129
d08e54002b We add the input decoration only when the focus is in the input
eef12f8734 Support using webpack's process: 'mock' (Microsoft/monaco-editor-webpack-plugin#17)
f853267a5b #60211 Show message when data providers are not yet registered
87ce9c3f24 Add a setting to control cwd behavior on terminal split (#60949)
94e2018c5d Fixes #59846: Clarify that documents get their end-of-line-sequences normalized
06fe5c4f8b debt - remove TPromise.any and use Promise.race instead
0b9efda561 debt - more TPromise migration
eda14d219f #60749 Show code on the last line
5c1a341f5d Fix #60749
89ca41a313 yet another attempt to collect feature insights.... #57093
88550a6fbb storage - more telemetry (integrity check, more times)
83cfe7dd09 fix tests
1c102c7938 fix #61067
912f1f79c4 Announce terminal number every time the terminal is focused. (#60632)
37ee18a194 storage - remove "allExperiments" if empty
82bc4af2d6 Fixes #61096
74f09acca9 editor - remove code that is handled by cancellation token (for #60163)
fcad21ec75 Fix strict null errors (fixes #61097)
14b837a2ab bump windows-mutex@0.2.1
799bc78af5 Fix parameters not having commit characters
3d0558efd8 Split coalesce into inplace and copy version
46d8bb8033 Strict null errors
5527b1ee42 Fix some simple strict null errors in extHostTypes
a6ee11199d Fixing a few more strict null check errors
a975e59eaf Update applicationInsights for #60585
924dd92b19 Merge pull request #60996 from banuragprdxn/master
a1f0c4b5ee Revert "Don't set en_US.UTF-8 on Windows when setLocale is false"
be7b3e4b2b Strict null check files in base/common
9b8d59a0ab Fix external terminal title
8907e1ea86 Add terminal frame time logging when its slow
b239d2a3a0 Strict null check files/test/electron-browser/utils.ts
7d80b00cb0 also use $mid as version id and only accept external and fsPath from the most recent version, #60163
1f63cd8397 Fix a few more strict null errors
f3eb7ada74 Don't include extension actions in tab order until focused (#59861)
13c5233796 Fix build
2ce9665b30 Allow globalState to be synchronized across multiple windows (#61024)
c8e7e58cd0 Merge pull request #60940 from laphets/fix-findWidget-btn
ebeff1000b eng - less TPromise usage
f9d93e884d Fix #60454
bce97cb557 Merge branch 'dbaeumer/57148'
193680c353 #60804 Quote recorded keys
c6990d2ed6 storage - add a test that stores a single very large item
f74c791449 Fix #60804
8dc8b0cdbf storage - less data persisted
7f4bf92c84 Fixes #60961: Use quotes for font family in a consistent way
832a49c79a Problem matcher for strict null checks
9d4e3cab60 Fixes #61051: applyTo is not honored when overwriting a base problem matcher
8947e963ec tweak strict null task
3119fa53e1 eng - more strict null
5df93623cf add strict null task
d641ef85ba null checks
388d29d258 null checks for ipc
0a27e9437a eng - more strict null checks
9d292bcb1f storage - clean up duplicate keys (for #60935)
c6c85e31d0 fix #60935
453b31b4ef eng - strict null checks
f6e5449a70 Fixes #60452: Clarify root cause of exception
1da6593b3d tweak alignment, #44860
f41f2d35ec :lipstick:
87dee2b6f9 storage - telemetry around errors and perf
87adbff43b #53526 Do not use Promise in utils
1919477035 Fixes #60450: Serialize circular structures as null
cb1d4bd064 Have a more precise computeDiff result
c0f4d570c4 fix #60753
c762e7868a fixes #61033
a158a8d4c0 Fix #60834
299050a853 fix #60694
5390806420 storage - :lipstick:
52328650d0 more TPromise removal
eeab2ae9f6 storage - remove shutdown reason from event
7687a1473d null checks: label service
ae90cd7b9e workaround for #60960
7688411a9c fix #60394
f757ab42b6 show file icons in suggest widget (no folder icons yet) #44860
a7113dfb5e use getIconClasses and add default (which currently always wins) #44860
8c22f1ca41 bump windows-process-tree@0.2.3
a0b91c2c5d scope assertStorageValue to workspace changes only
cdaffba08c Remove search-rg tests from .bat
2fdd6c1021 Refactor search - add config to run search in EH
dd9b271f7c bump distro
1c8bdc147a bump vscode-nsfw@1.1.1
07271b840e Delete search-rg in favor of internal search
a32b10881b Run file search in EH
5c23d38a09 Refactor search - move file search code out of ExtHostSearch Not generic now, maybe in the future
ab1a75708f Update scss coloring tests
fb606be779 Add typings for strict null checks
148c2c41ad Auto adding files for strict nulls
04c118d1d8 Fixing a few strict null errors
a57e7abae2 Remove deprecated js/ts completion settings
a3fa7ad178 Adding some typings in npm scripts
63d0559cff Don't use strict mode on gulp ts files
14ef4255d6 Remove duplicate switch case (#59677)
d458ca877a Set css hierarchy for webview file icon in the light theme (#60990)
e07cacd1f2 Refactor search - rename files
d616c781e0 Refactor search - remove search-rg text impl
dc2206a1d7 Refactor search Fix integration tests
52e7f1c9fe Refactor text search Fix strict checks, multiline search
c26d6e6c93 Refactor text seach To allow better code sharing between EH and search proc
ee40fa3e0d Text search in EH
73461169ab CSS highlight for font-family 'cursive' and 'fantasy'
08cefacac5 Ensure run active file works when no space is present
fe51ed01dd don't access body on failure; fixes #60998
66c88aa2bc Auto adding files
1815897415 Auto add strict nulls
689abd4911 Merge pull request #1 from banuragprdxn/banuragprdxn-copy-change
09ebaae394 Rewording / copy change
10b383c911 vscode-xterm@3.9.0-beta9
c5c0a7d29a vscode-xterm@3.9.0-beta8
ef8bb5b845 Fix #60672 - don't start search if token is already canceled
51103bd6c6 Merge pull request #60917 from aphexcreations/brendoncrawford/fix-term-helper-config-test-error-fedora
3266781c5c remove extra margins on completion hovers with markdown (#59786)
d4dbfa3c29 debt - remove now obsolete smoothScrollingWorkaround setting
db0dd58479 storage - be more "daten-sparsam"
c1af5ff797 Fix bug of storing duplicates in currentOrPreviouslyRunExperiments storage key
eed01cdc78 storage - remove unused
a63b9e179b move getIconClasses so that it can be used from the editor-layer, #44860
f3a560eef8 extract getIconClasses so that it can be moved, #44860
4fe451d71a move DataUri so that getIconClasses can be moved, #44860
ade6047773 use IconLabel when rendering suggestions, #44860
b72fede474 strict null checks (#60565)
655682c04e Fix eol character in debug test
89fa49400b Strict null check terminal Eneironment/actions
ab63c5d4c9 storage - fix missing disposable
62eed25cd8 Fix tests
8c52eb3746 Fix tests
5e2c5191a8 Fixes #60047: Running scripts with right click not giving feedback when it ends.
2c93ec4a2d fix #60925
957518fdff [folding] add null checks
5d645696cc strict null checks (#60565)
409e61c5ca Fix #60955
c19f675af9 storage - use void as return type
0a70cc6d46 Fixes #60461: Cannot read property 'command' of null
ddd0490622 storage - tweak log message
5a61ae11e7 :lipstick:
db592233ee fix #60459
477f1c18ad storage - add action to print contents from DB
5e8d5af6a1 fix #60449
329731090c fix #60457
25863af012 Fixes #60458: Cannot read property 'message' of null
550a39facc :lipstick: remove unused argument
2adaa4737a :lipstick: move snippet completion provider into its own file
5a38563b0b fix #60247
e3062841eb fix incremental compiler
3b6e25b020 [folding] tpromise-> promise
ca0f47124d fix test for #60746
41b99bc0cb update tests
6a5b2d6889 Revert "fix #60247"
dea4edf65c add test for #60746 (failing) and #60737
55ed150f27 Merge pull request #60539 from garymathews/issue-27393
2e33dbc714 strict null checks (#60565)
dce7f1bf48 Fix bug for prev and next button findWidget when nothing is found
bb0b08b720 fix #60298
05e1c11111 Merge pull request #60875 from Microsoft/ben/sqlite
5e67c08dab sqlite - onWillClose => onWillSaveState
6187c66727 sqlite - reduce pressure on storage
d68c05c3d9 sqlite - support in-memory when running ext tests
2dcc9b085c sqlite - add some logging
55b9f52f93 Merge pull request #60831 from aaliyah03/patch-1
5af04fb9c0 Fixes tests error with faulty OS check when OS is Fedora
6287407474 markers panel: accessibility provider
59d754d204 markers tree: open to the side
f25cde13be markers tree: pinned
9a0a525f96 fix markers panel input box focus
0f71aebcb5 fix build
ca0687c938 proper tree twisties
ab177f9baa tree: docs
d654635f62 tree: cleanup
de36f4c272 Update README.md (#60903)
a6c1151b32 sqlite - stricter rules for *.node files
e83160bd19 sqlite - fix tests
c61ee508be use vscode-sqlite3@4.0.2
248bef1fd4 sqlite - fix compile
e7c47cdf9c sqlite - fix compile
b843906c3f sqlite - selfhost on DB, bump storage delay
f0a2aa5551 sqlite - fix warnings
982051a36d sqlite - fix close boolean flag
0c5a3da3cf sqlite - fix tests
06476f7f8c sqlite - fold inserts/deletes into one transaction
3560e67017 sqlite - reduce changes
e7ddb88e1e sqlite - fix compilation
d3e13c97e5 Fix explorer inputbox alignment
ee2d4a1c9b sqlite - trim trailing whitespace
2f4af9744c sqlite - remove storageHome for now
3ba85cbce6 sqlite - more renames
37cfa4ea29 sqlite - renames
a49ad0c525 sqlite - rename to storage service
32f401fb93 sqlite - storage => legacy storage
e4b21b6794 Merge branch 'master' into ben/sqlite
7e9546a39e sqlite - memento conversion
d2067156ea sqlite - more next storage adoption
fc7d9578d5 Update Contributing.md
cdabfc35e0 Fix search smoketest
3d3df21a92 Fix #50676 - unreponsive window for some searches in EH
36aa4dfd23 Temporarily remove shell helper
1e2b78d601 strict null checks (#60565)
49f8bfbc42 Remove editor contribs that have incorrect assumptions about editor API
9a2bacc635 strict null checks (#60565)
68b9bd59e4 Exclude duplicate typings file on windows
3b30105213 Use files instead of includes
cadd6586c6 Auto add to strict null checks
3fcb671444 Use es2017 as target for build scripts (#60707)
36b60430f5 fix GDPR annotation
0e7b34db42 Attempt to fix build
5bd13a8cee More strict null checks (#60565)
4eb61b9ada Strict null check windowsShellHelper.ts
7087e41ee5 Strict null check terminalCommandTracker.ts
fd12842eb2 fix marker model tests
ee0a36970c Merge remote-tracking branch 'origin/master' into joao/markers-tree
9ef5f082e4 remember to clear cache
19f030b2ce markers panel should focus input when typing
4c781f050a markers: tree element
b368ea76fb list: renames
6636ad9d08 beware of sync/async promises
084fb5ccd1 sqlite - more adoption of next storage service
26e3925377 strict null checks (#60565)
4716afaa20 strcit null checks
fbdb6f529d sqlite - more next storage service adoption
654015a44b editor/common strict null (#60565)
113459ae64 sqlite - next storage service adoption
90fd44c102 Merge branch 'master' into ben/sqlite
380256ba37 tpromise => promise (#53526)
46d1426b7e Strict null checks (#60565)
8ff27229f2 fix #60333
3b95170b06 remove console.log
4cffff9f6b fix #51013
931c22033d SelectBox: Use visually-hidden for describedby with VoiceOver. Fixes: #60429
1f482cd06d Update markdown grammar
e5f9b64efc Remove strict null checks from test.sh
fa0b79434b Remove windowsShellHelper from strict null checks
e05b33163c Re #261. Update comments only when visible editor changes.
8476cae78a Pick up TS 3.1.3
69fd947d76 Mark types as nullable where we explicitly assign something to undefined
7c0bfb91d4 strict null checks
ffbe67fef4 Annotate a few more null assignments
484dcc1ff8 Update distro
adfb849950 Settings: Labeling for "Modified in ..." Fixes #59492 (#60226)
97720f61cf Merge pull request #60674 from Microsoft/misolori/file-icons
29d97683a1 Add null annotations for `x: T[] = null`
0318e90c93 Add null type annotations for the common `x: T = null` pattern
da546f5d5d Add null checks in filters and context keys
0c403f82c3 More strict null (#60565)
3ace1898e7 Update file icons to use file type icon in small views
cbd629998b Fix tests
20ce983683 markers: messages
99f78e83d0 markers: filter stats
31a1ec61e5 vscode-xterm@3.9.0-beta7
7b1f444fe5 Fix a few more simple strict null errors
dcd3744554 Add fallbacks to fedora/ubuntu font hacks
05f3932a35 fix #60270
87e290d040 markers cleanup
f593797269 markers: cleanup
0b4b0dccd7 More auto adding to strict null checks
90cedfc1ef markers panel: collapse all
9b1013acc0 markers context menus
e7ba036a53 Auto add more files to strict null check
428eac303b Adding a few more files to strict null checks
c61e9eccb3 null checks: history.ts
3af9e4568d labels: strict null checks
3ba326658d More strict null sources (#60565)
b885360659 markers panel: bring back context keys
e6f2819b4b strictNullChecks in terminalWidgetManager
be2ac1749f use thenables for proposed clipboard api, #217
4728d11f8d markers panel: finally mouse and keyboard navigation
ac5b1f9afa Merge pull request #60559 from Microsoft/misolori/activity-bar-icon-cleanup
ea0a067680 Strict null check for event.ts (#60565)
3f7f72dd2b debug: do not prepand DEBUG_SCHEME to paths
c3ed7d3ba0 sqlite - some more service adoption
3e5bdc4571 Better typings for IteratorResult (#60565)
afe13242dd expose browser event in list widget events
52bb5aebbe cleanup
4ad3ac006b Ctrl/cmd + f in terminal find widget should be a no-op (#59785)
740ac11a17 More strict null checks (#60565)
db6ebe93f8 remove now obsolete code
3aba97617c remove IListOpenEvent
b77b9af3da sqlite - first cut next storage adoption
812b241290 debug: on restart, make sure to first disconnect and only then run the prelaunch tasks
03222d2027 sqlite - relax storage value assertion
174bf8b750 sqlite - detect cross window changes to localStorage
ee34a6ec56 sqlite - ignore same updates/deletes
ae2f5e1c92 Add more files to be strict-null checked (#60565)
dc2868ac07 sqlite - have an event before storage closes
56df542840 Revert to previous check (fixes #60243)
0b306d17d5 Revert "removeFromRecentlyOpened Command Broken. Fixes #58131"
c79caf02bd sqlite - renames
5afd008942 sqlite - renames
4f87f9061f sqlite - delegating storage service
b782790ca4 sqlite - faster events
98a67aea25 Reduce usage of WinJS.Promise (#53526)
f151c46b17 Fix test 🦇
2d4b7cb12e Move strict null checks from precomit to test
a2738f73e5 Auto adding eligible files to strict nullchecks
7beb02d31e Add more files in common to strict null checks
77de533b5d Strict null check a few more files
ab2fbe9554 sendSequence should skip shell
517469041f Add strict null checks scripts to precommit and to tfs builds
c1d0930765 Opt a few more files into strict null checks
242c63854d Remove include and exclude from base tsconfig
104275cb9f Add tsconfig.strictNullChecks.json
7e742e1f31 vscode-xterm@3.9.0-beta6
17d674aadf Reduce usage of WinJS Promise (#53526)
b211b7133f Clean up icons to fit on 28x28 square
d3d3236565 Fix #60455 - handle canceled local search before remote search
6eb6654d74 Fix #60456 - null check
75adca78ca Fix #60460 - null check uninitialized range on SettingsGroup
f62b9a3194 Fix #60451 - null check
25f3e00705 Fixes #60318
0f02aa065e Revert "add select all role for macOS"
bc4de3dfc3 :lipstick:
3a88cefde4 remove unused code
12074991dc sqlite - more renames
0df231f5eb sqlite - renames
1b70f380b7 sqlite - add some perf measurement
d3377b0d39 debug: send out name with setVariable request
c54c137acd fixes #60448
0bbe8e28c4 update minimatch
febf978c28 cache panel body size
d729e50521 Fix standalone editor gulp scripts.
4312f42a4f fixes #60446
0d9d26b127 debt - shorten workbench URL and print warning if exceeding limits
64c976dda4 fix #60437
bac418779f Merge branch 'master' into ben/sqlite
cc5e2b41c3 Multiline match hint UI for #13155. Implement search.showLineNumbers to fix #39219
f3f7d97129 Fix some search tree display issues with action bar and count badge
c4494cc1be Much faster parsing of long lines/multiline matches from ripgrep
25179088b1 Fix search result bubbles showing in the wrong place in wide mode
2d0dd21a4a Pick up TS 3.1.2
e6d219aa14 markers tree: filter count
5f69bcbc03 revealedCount -> renderNodeCount
d4faab68b0 add ITreeNode.visible
f477b54fb4 remove todo
b2bee0c2c0 :lipstick:
0da607307d markers: filter with highlights
797161bd32 vscode-xterm@3.9.0-beta5
bab47f0ffd add select all role for macOS fixes #19003
11fe99a694 Reducing menubar cache verbosity (#59992)
2c346822d9 remove context listener in menubarControl (#60169)
e9809b3cff fix markers filter
46b79144af Merge pull request #60012 from benjamenhogben/master
8d1d201911 remove workaround for #60018
a7db2fbb3c fix build errors
43f42a4ab6 markers: fix styles
40371ab59d vscode-xterm@3.9.0-beta3
def5463cc1 Merge pull request #60153 from ToothlessGear/feature_allow_disabling_replace_preview_setting
9ac1a92008 remove layout trasher which seems unnecessary, #60031
2afc8720d7 Merge pull request #59270 from Microsoft/octref/44625
53e166f796 perf - prevent layout trashing when remove/hiding parts splash
f9281d8317 debug: simplify setting breakpoint session data
9c9e316438 fixes #60018
8bd5387d37 Implement multiline search for #13155
17d36c47a9 minor polish
30eeffce9e fix instantiation service using the wrong scope to create services
cc31abab70 fix keybindings editor
ed604d1fe7 hook in filter to problems tree
0ec0abe783 better fix for #60188
f255d10339 fix #60188
c94bc23449 cached data for extensions, second try
1de8905bf5 Change throwable var name
f4ed8a58d9 include reference to the usefulness of the built-in reporting tool (#60025)
1f83a8d105 debugSession: simplify return types where not used
6e6a67a53d repl: better code grouping
12a0b0e749 repl: fix smoke test, make sure to get proper state when becomes visible
ccdbbe13a2 debug: make sure to dispose of all sesions on shutdown
d166c0c8ca Merge pull request #60167 from Microsoft/tyriar/58357
53321de6d3 fix #60247
099c23febc repl: allow to inspect repl output of inactive sessions
7d6c474a8f Merge branch 'master' into joao/markers-tree
5bd6ebe2db move Promise back to TPromise in nfcall
5300bc54b4 debt - less TPromise usage
6ea40d7b9e debt - less TPromise usage
291f9af174 debt - less TPromise usage
711217acc5 debt - less TPromise usage
0741911a0f add test for #60232
fd655a5462 fix breadcrumbs keybinding select issue
fdf2dec52d Remove usage of TPromise from public editor API (#53526)
6daba7710a Migrate to native Promise in web worker related code (#53526)
99d97b5d93 Merge pull request #59568 from kscharlund/odd-indentation-support
a97e98b1ad :lipstick:
c1100eff93 disable cached data for extensions #60168
9e017425b3 Replace markdown-named-headers with custom version
7d95e3e5f9 Support markdown link navigation when duplicate slugs exist
0cfe8a1d7e Fix potential TSC error
f516d17267 Add support for TS RenameTextSpan
5f5488ce75 Consider "search.useReplacePreview" setting in ReplaceAction
09afa054ee fix undo, redo, selectAll on macOS (#60040)
ab8bc96039 Stabilize active terminal APIs
6a940ef13c Merge pull request #60158 from Microsoft/tyriar/60155
d4f8db74d4 adding ability to set checked state for menu item at registration (#60004)
b1a4f3203f fixes #60067
6b2c0d902b Reword description of "search.useReplacePreview" setting
5b03dcd69d Add pinning test for setting localResourceRoots
d01d178b3b Merge pull request #60154 from Microsoft/misolori/responsive-find-widget
d0ecfa0ba6 Adding pinning tests for vscode-resource in webviews
a2b1bf32bb Add terminal.integrated.experimentalBufferImpl setting
fd52305912 Update xterm types
d4f40dd755 vscode-xterm@3.9.0-beta2
00cd0c355b Increase max-width for find-widget
a342380e89 Add setting to allow to disable Replace Preview
6d8b6d39cc Remove css vendor pefixes for transition and transform (#60050)
a2455b79a0 revert "exploration"
ff085d3bc7 Fixes #59328
fc971b1674 electron@2.0.11 (#60143)
f6f37aa3a0 sqlite - hook in next storage service to workbench (in memory only)
61ee5fad06 fix typo
e69c3db65a fix #59966
f91e70bcdb expose label tuple in API, #56337
cfe3e33ce5 sqlite - implement a way to join shutdown phase with a long running operation
1580cd1846 first version of simple clipboard API, #217
d8b79267f5 fix list.focusFirst
07b01bf9ec adopt WorkbenchObjectTree in markers panel
b4681da86a wip: WorkbenchObjectTree
5893222e20 sqlite - first cut workspace storage service
b75dc69f42 update sqlite3.d.ts
5c720a08e8 comments
e202759899 repl: minor fix
96eb2ffc55 debug: minimal updates to repl title when repl is not visible
9cb4d4bbea problems: proper rendering
a39a101d42 Don't assign 'editor' label
75dc89debc more measurement prop...
fd4091b803 problems: first render success!
59f367a8b0 Merge branch 'master' into ben/sqlite
315d3524d9 Update status bar when opening a binary file as text (#59914)
2570a185b2 wip: problems tree
b65d113c0a prefix names with `prof-`, #59505
38acd799ea let modified border win over theme (for #26284)
14ba3e2647 less TPromise in editor/contrib
31f86f72bd update ParameterInformation#label in extHostTypes.ts, #56337
e891e2f3d1 Add border for dirty tabs (#59759)
005858ed7c add missing compile
9fa354a7aa update internal API to allow parameter label to be an offset-range of its the signature label, #56337
107e4bbd82 Merge pull request #60024 from douglasgabriel/remove_dead_code
7843e40d06 :lipstick:
83345df7a6 sqlite - first cut storage service
1358e90371 Update links on README.md (#60100)
3a82196fd9 "Configure language specific settings" should reveal the edited line
3b157682e1 Also respect useGlobalIgnoreFiles in file search, from PR #59717
95fa14ee15 Fix #60055 - "Configure language specific settings" must open json editor
fd6b2b3cce Fix #59400 - show context button when hover setting title
1e299b6733 Apply selection even when the items don't change
c09511ccc1 Merge pull request #60045 from w9jds/modified-in-navigation
30fbbd7af8 Makes Modified in scopes navigable
acbe81b942 Settings editor - fix starting when no cached state exists
5cee349ba5 Settings editor - fix restoring cached state issues
c98a972c4f Prevent "folder" settings picker from stealing focus on click
a59b03426e Send ctrl+k to shell on Windows
ceb8f18fb8 Adding pinning test for webview scripts disabled
7b8e463099 Extract duplicated code
23fedc5a3e Add pinning test for webview html update
676ea4b5c5 Improve test name
2f51e97117 Add retrigger characters to SignatureHelpProvider
2e8993b83c Prefer const
000f027497 Formatting
696fc1b48e Make sure we close old resource on ts server for path updates
03ed0959ee Improve message on update imports prompt
f87369e1af Treat json5 as json in the markdown preview
bb59097ab8 Update md grammar
a855416d70 make actionbar support different trigger keys (#60000)
b3ff3e4375 Wait for all editors to close before continuing tests
0136935c52 Improving webview test reliability and add test for preserve state on column change
3cb9b60d32 Add missing registers
8f1dbae0b7 Bump vscode-ripgrep with cache download fix
1f9981f55f Make webview test communication more timing stable
4ecf3e5388 Improve naming and use proper (optional) types
daec9ce7bb Update markdown grammar
f4f6c623c3 Make sure we dispose of webviews properly
866c6d6ff0 Merge pull request #59739 from NiclasvanEyk/master
23891f8781 perf - use IdleValue in suggest controller
0e60629c5a Bump vscode-ripgrep with fixed build
fac58fc8fe debug: DebugSession.getLabel() clenaup
332aa37160 fix tests
2f0fdd34f2 Merge pull request #60016 from Microsoft/isidorn/multiRepl
4a20075ecd debug: show dropdown in repl when there are multiple sessions
15952524a1 repl: readonyl input while no session active
74fae4d7df repl: multiple trees per session
414da9bf7e Removing dead code from
3f161f55c9 moved the rendering logic to a more appropiate method
0a2a195598 made use of _register for disposables
5ebcf70fbf :lipstick:
09c6c9a729 :lipstick:
2f28e6ba8a make sure to register extension point early
b8b7c3c3a6 sqlite - initial version of storage library
a1839ca21a don't measure, just do...
51cfd80859 debug: introduce replModel and move repl related methods inside it
3fbb09fac6 outline - work around panel madness
f0b51ea9ad Catch Throwable user editable
aa351d8293 debug: keep repl elements per session
ba0448d8bf add missing compile
148931476b more promise removal
f1bd5b63d4 fix #59939
7d30396d0c Add throwable to try/catch block
3dc960c0d1 Merge pull request #59797 from J-Graham/middle-click-breadcrumbs
b58200ca9f workbench.centeredLayoutAutoResize -> workbench.editor.centeredLayoutAutoResize
3cd0a546d7 Fix #59862
0c43f4ef3c clean up
b7639f6f3f Merge pull request #59883 from ritwickdey/fix-alignment
8d44ab61c6 Fix workspace test document count
b35721a71e Fix windows file search tests
fdb46fcc66 Remove unused var
3da9a122f6 Add test for restore scroll pos when retainContextWhenHidden is set
54df095e39 Adding retainContextWhenHidden test
6a4e027c41 Refactor our duplicated code
8151b1fc50 Add test for webview state persist
565f971f43 Add basic test for webview communication
a529621b3d Disable command uris in preview
03e65ebe47 Use await/async in tests
6d5214053c Fix local markdown document links for untitled files
4b2aed7bb2 let -> const
8ecebfb761 var -> let
38886a08c6 Workaround for misisng selection color in suggestEnabledInputs
5359560ead Update ripgrep version, use new json output format
1bf1bc2c0e Use async/await in tests
3ad13abc58 ÏSwitch tests to use await / async
f0b76b7ea8 Use async/await in tests
c9c8dbbc96 Use async/await in tests
38a2c24ca2 Merge pull request #59717 from skprabhanjan/fix-59364
a2cb37a3cf Merge pull request #59979 from benjamenhogben/master
e4172c25b4 enable dynamic menu on linux/windows (#59936)
70ee13e7fa markers: wip reduce marker model
3edd27449e add php try catch snippet
e4286549e0 Fix #59954 - minimum size contraints for settings UI
18c2ed8824 markers: wip remove filtering from model
eb3582ea10 introduce workbench.centeredLayoutAutoResize
573574c31e markers: move fixes gathering outside the model
5f7e387715 tree test: setChildren on expanded, unrevealed node
042eef08b6 Revert "remove flex from splitview"
8206f6a172 tree tests
6c24b5d4d6 tree test: setChildren on collapsed node
e7d39fc62d debugEditorModelManager: remove -range css classes, we use editor selection to highlight
bc8a3ef204 Revert "Vertically align welcome checkbox with text"
ce4c9c52d3 Better align with "workbench.commandPalette.preserveInput" (#37932)
73fee9f51a Merge pull request #59962 from FrederikBolding/issue-59744
5854177309 debug: polish color names for editor.stackFrameHighlightBackground
744d94ab42 don't try to use non-existing tracker
a5cbf6a7d4 list setRowLineHeight
ab734ccf4c tree twistie and contents 100% height
aab58cebec Fixed formatting issues
f523fd2036 Fire onDidHide only once (fixes #57852)
120c98ca02 statusbar item highlight should start at window edge
b5822be243 Allow themeing of debug single step line highlight
10a1d2a50a update grammars
f441229bf3 Split 'breakpointHasCondition' into two localized strings
84f1d0d438 debug: use debug scheme when parsing paths to uris
0bee1429e1 remove unused code
346906edd4 fixes #59950
cfc2a2212d custom 'html' tags are in red color. Fixes #56467
7ff8bda7e8 Accept on with selection, work around all items becoming active (#57850)
f45ac28666 Do not clear selection in single-select case (fixes #57850)
4db611a466 remove flex from splitview
1cac2f9e2c use position relative for all split views
a7b8fdb761 Merge pull request #59891 from yeahok/master
792bf8c554 themes: TPromise -> Promise
ed287f0588 tree: twistie rendering participant
6e2817629b :lipstick:
f036a7686b tree: missing disposeElement calls
5afd287581 Reset message in out-of-scope bot (fixes #58468)
038017705e fix #59364 - Review #3
7be0d1bee7 Not optional
2e00db8383 Add option to only show Welcome page in empty workbench
8795a9d642 avoid "NanTB" (for #50103)
fc251d651d tpromise => promise (for #53526)
9d89efe8b3 Remove unused import
1e5a57279a Removing or marking unused parameters
e8475ad59f Enable noUnusedParameters in build scripts
5de9c9bf8b Compile build in strict mode
494395f62f Adding correct typings for event-stream this values
86fbc62cf1 Remove some unused types and variables
b3f85e5f19 Add explicit any typings for this
1c3d41ea68 renamed variable to be pinned and added a check that data.payload is not null
a4b375a37c Added link directly to main wiki (#59884)
1470548b0f Remove duplicated typescript dependency
a9944e6595 Move some build specific packages into build
6aa7463ca1 Remove unused gulp dev dependency
90fc4c90d6 Merge pull request #59704 from usaatyuk/persistent-settings-search
a8054867c7 Fix #58758 - issue with absolute UNC glob patterns in ripgrep
45d48f350e Fixing monaco build errors related to require
f7456ebf90 Switch to use standard @types/node types instead of our customized version
63e3162bc9 Switch to use `@types` for pump
38fbec9568 Converting some `require` imports to `import from` imports
293c9cb5a6 Fix #59816 - wider exclude control input box
40a80d0197 Fix "can't read 'focus' of undefined' error when resizing settings editor while exclude 'add' input is visible
26365c8957 Add typings for emmet #59803
ffda5ba4f4 Merge pull request #59781 from Microsoft/misolori/button-focus
e1feaf30a1 Fix #59397
7026335451 Switching to use @types where possible in build
ac737307d7 Enable noImplicitAny in build
a54e5f54d6 Enable strict null checks
fe45a7d21f Fix remaining strict null errors in build scripts
5862b41657 Fixing strict null rules in tslint
31e0752065 Fixing strict null checks in build util
56a161042c Fix strict null errors in api
0d3682e6bb Fix strict null errors in tfs
ddc5eeee01 Fixing more strict null errors in build
6b9ec57923 Fix bundle.ts for strict null checks
7c76caffe1 Revert "themes: TPromise -> Promise"
09d9d0bd52 Cleanup margin/padding
ffbd9a7979 fix #59561
c301189c43 return of the dynamic menu (#59855)
b294734e84 debug: introduce debugConfigurationType context key
8b1ea4bcac fix #59908
c551e35a2c Focus interface overview (fixes #51983)
82192c3bcb :lipstick: tests loading properly
fcd341cc72 Fix heading read out as list (fixes #51986)
73363f6133 themes: TPromise -> Promise
683a76f295 use FileDialogService with vscode APIs
7d7c27cf3e less strict checking of rename locations, #58907
856a0daab5 tree model: working!
91336e2262 fix compile error
26ebe97ddd data tree: first steps
90a6b23b48 Merge pull request #59897 from PunKeel/patch-1
1863bcac81 outline - don't relayout when height didn't change
fa1fb63f97 use measure util for font things
9583bac188 dom - use measure/modify to prevent layout trash in breadcrumbs
119f9ac3c7 debug: some comments
76a2da6070 move font info creation to the start of an animation frame
0d93c8409b debug: clean up focus transations
a0161614c7 Removed duplicate "the" from documentation.
1270434326 Revert "clean up"
dc7db2705b Preserve focus (fixes #51976)
e84a229039 clean up
528da15df4 perf - avoid layout trashing in breadcrumbs
23fe4acb45 tree: abstract tree
b8f2d15d45 tree: rename
e142ac1427 tree: perf
542375c6d5 Fix R icon size
9732963bd3 only have the n second timeout for prelaunch tasks that do not send an active event
52420590ce tree: fix npe
0b55add151 tree: expose event
2c72fd0f07 tree om: setChildren
f971baa7ec tree object model tests
7513c28883 tree om: use start index
9fc7970fb3 tree object model: first sketch
e9a3ed3d5c tree model: remove a few extra loops
4b5243ff2a tree: node.visible should be boolean
53add63b68 tree model: initial model recursive filtering
7c96ba71ae tree model: cleanup
427663d35f debt - less TPromise usage
81c6d626e3 perf - don't compute config-context keys eagerly but on demand
46c97fe413 #53526 Use Promise
484b075e8a fix alignment
744d9eb832 Fix compilation errors
d1571770ce debt - remove BufferPool because allocUnsafe already uses pooling
a36823fc06 debt - don't delay extension host starting that much anymore, move (and fix) timer marks
9588b6fe87 Launching "code" from git bash fails with "cannot find module" error. Fixes #58950
315299eddf #59861 Remove TPromise from extension management
3eb33255e3 #59861 Remove TPromise in Extensions
90171dab97 #53526 Use Promise
78724354b9 Fix json
4863318300 Merge pull request #59754 from Microsoft/tyriar/53526
6ad61f018a Getting closer to shared config #59803
5ae10c4ee3 Fix #59696 - fix settings container sizing, and shadow positioning when the editor gets narrow
2a01db150f Fix #59801 - use shared extension tsconfig for search-rg
92a9a07213 Remove duplicate blank lines at the start of some extension src files
be38e56996 Remove duplicate blank lines at the start of some files
f40ca995d5 SuggestEnabledInput - account for slightly transparent text selection, when matching native text selection
ff957050db Remove use strict in extensions (part 2)
d4edb9abcc Remove use strict directives in main VS Code src (part 3)
8087b0a8d8 Remove use strict directives in main vs code ts files (part 2)
c63c97c128 Remove use strict directives in main vs code ts files
dd3e2d94f8 Remove use strict directives in extension code
4c8e61c049 Remove "use strict" directives in extension tests
7ebea5fba0 Remove "use strict" directives in tests
cfeeb33345 Ensure that normal tsc compile still works
0434bd7915 Clean up type inclusion logic
02593076f8 Revert including yazl types
de6064c90a Allow copying text from parameter hint widget
660209ca74 Import order
8869632ba2 Prev/Next Sidebar View
4e50ae607d Prev/Next Panel item
36a2a4b9cf Track experiment id
c794db9e31 Switch to use a few more @types packages instead of our custom versions
f5850c9510 Try using @types for typings instead of our custom versions in src/typings
aadfc796de Adjust padding/margin so buttons line up
0fb324496a make sure `ensureLowerCaseVariants` has been called
63d6fcf8f3 better fix for test
925269a467 Merge branch 'master' into tyriar/53526
f8a5a48471 do not use timeout
a161d235bc fix tests
7e87d06a4a Skip failing test
e6454e6cbc Add workaround some completions unit tests failing with null access exceptions
cd1eb20dc0 Fix tests
d5912ce583 Fix tests
cde4ad5bcd Don't force update webview content when retainContextWhenHidden is set and contents have not changed
686e741624 Vertically align welcome checkbox with text
4b427941dc #53526 Fix compilations
2b902734c1 #53526 Use Promise
a6f0ff5d93 Remove unused typings
fb51020ae3 Switch to use node module resolution
c050c96b97 Update json server to use shared tsconfig
9116ec29ab Use shared config for html server
ef5bd4810a Use shared config for css language features
60287ebe51 Move configuration-editing to use shared tsconfig
69056ab090 Upgrade extension-editing extension to use shared tsconfig
e12fbaa5cd Update html, css, andjson clients to use shared tsconfig
6d11792abf Change the git extension to use shared tsconfig
52d3961c2b Update more extensions to use shared config
e4e040c6f2 tree test: back to level 5
a55274bf18 tree: collapsed visible node should still recurse when filtering
60ba9db9d7 tree: fix filter & collapse
321df0350f Fix reject -> resolve
f655efaa1f fix #59364 - Review #2 - build failure fixed
836c4fc8d4 #53526 Use Promise
a46d73ebed :lipstick:
d6eca6882d tree perf collapseall
19e63edfd9 perf - tweak defaultComparator
e808161b9e perf - pre-compute and cache lower case variants for label, sortText, and filterText
4623835328 fuzzyScore - allow passing of lower-case variants of things, allow passing of start positions, move whitespace starts to completion model
fadfadeab6 remove console.log
70d90e43e6 - Use svg icon for record keys - Move clear action to search input
a1fa2a89d6 debug: tree clear focus and selection and focusing into input box in trees
a8b2950a12 Repeatedly seeing "Disable other keymaps" (fixes #55272)
c4928076b7 fix #59364 - Review #2
1d40f3f25c Off by default (#45853)
3af967d359 Merge pull request #47886 from andrewtomai/Issue-#45853-checked
0c7c4c172c some more jsdoc
a157002380 debt - remove suggest adapter and use CompletionItemProvider from modes.ts. Also fixes https://github.com/Microsoft/monaco-editor/issues/985
0e8fe348ca TPromise.join -> Promise.all
977fc70d40 Merge branch 'master' into Issue-#45853-checked
f1461f742a TPromise.join -> Promise.all
1faa060037 streamline APIs of chockidar and nsfw
c706d49539 TPromise.join -> Promise.all
7b64c7af5b Automated response for *as-designed (#42976)
d00e5cb041 debt - replace CompletionItem#overwriteBefore/After with CompletionItem#range
504ab3bb33 fix terminal test
3f12ef35a8 debt - modes.ISuggestSupport becomes modes.CompletionItemProvider
a951efafd9 fix settings state being persisted when it's closed while invisible
c994ee22c9 tree: update invisible node revealed count
a44e45188c tree test: refilter on load
a74af7fe7f list: fix scroll height issue
cab46acc59 tree: recursive filter tests
c3f0d70bfc :lipstick:
f1cedc0b26 tree: more getNodeLocation tests
ebf10a3056 tree: getNodeLocation tests
5731c0478d debug: resolveConfigurationByProviders on restart
65685d302a debt - one winjs promise less
0c2388a008 perf - simplify cached data env var (enabled cached data for the extension host)
d3a6a23449 Remove synchronization
eeca0a4f51 Merge remote-tracking branch 'origin/joao/tree-filter'
cae2a79139 yarn lock
9edd6335b4 Ignore *out-of-scope
429b7e2848 Fix TS 3.1 error in "extensions/json-language-features/client/src/utils/hash.ts". Fixes #59761
4c963c0895 Merge branch 'win-sign'
0604b4f7c4 Merge pull request #59758 from ronihcohen/pascalcase-snippet-format
11590a3102 fix #59763
596104a2ed fix #59768
bd4d782d49 Fix default keybindings file label
eb7a018486 Do not open default keybindings by default
24179e0bf3 Make Open Keybindings File a primary action
d848101d9d different fix for #59733
eafa0add6e fix #59752
38a5ab89ef optionally sign windows setup
17da77f9e2 CR Fixes
d8c58630a6 more logging (for #59752)
ee321dcd2c build - auto release "exploration" builds
227e98f893 fix #59733
72fcd264c5 Update calendar
6903256cd3 Revert overflow change and increase margin to show outline
e9301e67d5 fixes #59764
f0bfe7ce71 always restore grid, even on error (for #59752)
219b9461e5 stop duplicating actions for tabs management when using macOS native tabs (#59793)
c306aafbd2 Fixes for 58176: Middle clicking files in breadcrumbs explorer opens as preview
ccb63aacfa Removed duplicate "the" from documentation. (#59736)
feffb38103 Make sure the configs values are overriden properly
936742b5d1 Onboard npm to use shared tsconfig
6769079c0d Onboard jake to use shared tsconfig
1d192bb4f0 Onboard markdown to use shared tsconfig
950a3ff867 Onboard vscode-api-tests to use shared tsconfig
402106a699 Introduce a shared tsconfig for extensions
199c51f4a5 Enable no unused parameters
55567633b3 Enable no unused parameters in vscode-api tests
f1c7c19a36 Fixing some strict mode typing issues in emmet
86ceb0c84e Enable noUnusedParameters in configurationHelper
02e4aada63 Remove unused
dece532913 Prefix unused with _
90041e8bc7 Use await for tests
09c738074e Converting many test functions to use arrow functions
316a067c27 Convert test to use async
2025636974 Convert test to use async
e87867c917 Convert to async
735f6a7bb9 Merge pull request #59713 from spahnke/initialize-scheme
8ab695c975 Merge pull request #59772 from Microsoft/tyriar/59765
ba7a41907e Revert "TPromise.join -> Promise.all"
f2f8b7cb08 Remove built-in toml basic language support
a50e3fe64d Simplify teterminal ID retry mechanism
78d8277315 Revert bad fix for unit test as part of TS 3.1
d37076a596 Build VS Code using TypeScript 3.1.1
a9767b9083 fix #59364 - Review #1
7b9b2cb998 Adding pascalcase to snippet format
0d0bfe8ddc Adjust phrasing to sound more natural in CONTRIBUTING.md (#59749)
931223d9d3 Fix sass file reference
68b2f0f86c Remove TPromise usage in execution part
61ae1599fb Remove TPromise usage in terminal part
a76804ef19 Fix #59741. Undo stop before the first color change.
3288426fcf Fix #59502 - maintain 1px border on select when focused to keep it stable
59545128b2 Fix #59393 - fade in settings ui context gear icons
1d2ec4020f Fix #57281 - use configured workbench selection colors for suggestEnabledInput
f25e9c1069 TPromise.join -> Promise.all
8ee605ede4 feat: force mojave dark mode support on even though Electron is not built on the 10.14 SDK (#59742)
66dcb50e61 gulp-atom-electron@1.19.0
20566a4404 fix windows continuous build
aaee349207 vscode-xterm@3.9.0-beta1
3eea5fae43 Revert "vscode-xterm@3.9.0-beta1"
e367391822 debt - use readonly instead of getter
c2d0322c42 more shared snippets
6dbb27e692 debt - make actions return a Thenable
01c138cd7d update continuous build
6617952c18 prevent old yarn usage
d4fdc9886b bump gulp-atom-electron
4567f19ef8 debt - drop getActions() support for editors
b38646959c Off by default (fixes #37932)
9cd2bc03b8 Prefill quick open (#55752)
bf0b659f44 persist settings target and search query
cdb80f4dcc Merge branch 'master' of https://github.com/Microsoft/vscode
070ed69049 fix resources.test failures
0a5343aa97 implement [#53133](https://github.com/Microsoft/vscode/issues/53133)
7829e50427 debug: fix bad promise refactoring
54c51f2f23 QuickPickItem.alwaysShow (#59232)
5ef7bf6b4b debug: TPromise.wrapError -> promise.reject
2ff10aaf20 debt - some TPromise removal in editor/contrib
8f20c5eae8 vscode-xterm@3.9.0-beta1
79fbea3663 explorer: TPromise.wrap -> Promise.resolve, TPromise.wrapError -> Promise.reject
f9d63a1e37 debug: new TPromise -> new Promise
5e943b7729 debt - lazy clipboard service
c0bddd3f23 workbench/browser: TPromise.as -> Promise.resolve
f3662d065e register label service in shell
7d7c0a7402 explorer: TPromise.as -> Promise.resolve
3424823351 Add 'a11ymas' command
d0b45d2d3c Added actions to the 'No Settings-Found'-message
6ade98e776 Merge pull request #59639 from dierksen/swift
15b78a8c97 debug: TPromise.as -> Promise.resolve
19207ed443 debt - slice once, loop once, sort once instead of three loops, three new arrays, and two sorts
971dbe5af6 Merge pull request #59406 from DickvdBrink/patch-2
5fb1e8b8b0 Merge pull request #59631 from Microsoft/tyriar/small_type
2e0d310d14 Merge pull request #59629 from Microsoft/tyriar/shell_os_only
d65a12745f debt - use native promise in async#always
d69e8d3b47 debt - use statusbar service for global progress message
f666c4b047 activity titile should be manage
e3bb3e769b linux build: limit child concurrency
9c042522bf linux build: use tmp for home
bd92f9c398 insta - use lazy instantiation on main side
55d96d9894 fix windows tests #58985
d42c663859 insta - make sure to inherit lazyness
7f6f065943 debt - less winjs-promise usage
81b995a25d debt - less TPromise usage
258f8dc822 fix #58985
40f3405131 update darwin node and yarn versions
f5f602bdf4 update linux build node and yarn versions
59d26e223e Running extensions editor: Convert workbench editor actions to commands
f74a50e353 fix #59469
00702d3333 debt - command service uses real promise
87e5717630 debt - remove TPromise from opener service
13436602b1 Revert "build script: log dowload finished"
7b521edfad Fix #59731
c8ce044fa3 debt - remove TPromise from bulk edit services
9e81c8f25f Revert "debt - remove declaration for WinJS.Promise#any"
706ada4612 debt - let sequence and first use native promises
7278fdbdb8 debt - simplify asThenable
9496bb79c5 debt - replace asThenable with Promise.resolve
75968799b4 use python 2 for builds
75f5ea2539 debt - asThenable returns a native promise
61a2faf7e4 debt - remove declaration for WinJS.Promise#any
fb75f32be9 #59346 Use EditorTitle menu id
c69d51adb3 #59346 Convert keyboard preferences editor actions to commands
941c11cfc1 allow undefined publisher
258e8fc981 Merge pull request #59464 from Microsoft/isidorn/debugActivation
1b0326386f Merge pull request #59602 from Microsoft/isidorn/activity
15192ac88d Merge pull request #59617 from Microsoft/isidorn/debugStart
ca19bd62c6 Merge pull request #59621 from Microsoft/isidorn/panelPosition
0693d0f674 compare fsPaths instead of a fsPath and a path
c9cc149c48 Fix: #59364
a144e2fa9f insta - implement set trap
74b73dfa63 fix telemetry
f58eb4df70 insta - use the right service...
324f0ac202 instat - use IdleValue and Proxy to delay service creations
58a581a3d2 don't use performance.now
441a5ccf0f use proper proxy declaration
d2d9ecfc4c perf - use idle callback for lifecycle eventually contributions
983299d9ae debt - move tracing flag up and some tweaks
9435f9cbc7 use IdleValue to prevent overly eager service creation
5867865b25 debt - move runWhenIdle back to async, add IdleValue<T>
964a137c15 :lipstick:
7da3763214 better instantiation tracing
cbdf8ae082 add tracing to instantiation service
5aa4266a6e :lipstick:
e199e99ba8 debt - use TypeScript3 feature to nuke IFunctionSignature1 and its overloads
e372a53542 debt - move graph close to its only user
558a22d104 debt - remove unsued code
a272ebcfa2 better fix for #8038
5592c2ce4a Merge pull request #59636 from qcz/patch-11
3f732dfd01 Merge pull request #59638 from qcz/patch-12
b766e3b22a [StandaloneEditor] Initialize static field 'SCHEME'
0c4fa8a7b5 October changes (#59712)
13100f2e43 fix #59655
77a3b330ae catch node 9 usage
707787c5b8 update yarn.lock files to use integrity
e1e0853f4d update build node and yarn for linux
be912909e4 use hosted build agents for linux builds
fc903f7ffc Merge branch 'next'
52caa1a44a refactor code\windows: Add FileInputs, IEmptyWindowBackupInfo
d06eae0f23 complete IWatcherChannel
357506ab33 add NewWindowOptions
5f1e86ea2b add FileDialogService
9ba00291c1 labelservice: match prefix, take longest match
39bff6cf44 polish
3cfe173979 build script: log dowload finished
d5b94eb3a7 Version bump
c432054ae5 Merge pull request #59642 from Microsoft/tyriar/lopsided_quotes
744669a9df Update swift integration test results.
4125f7a045 node-pty@0.7.8
bc422b8b4a Use textmate/swift.tmbundle for Swift syntax.
eb05b3ea61 Fix typo in jsonSchema_v2.ts
b84da3b3ab Fix typo in processTaskSystem.ts
52e9425445 Add missing return type
ad9ccc4435 Only sdetect shell for the current OS
e0e2738819 fix #59623
483f9cbe8e move sidebar location in sidebar title area context menu
213eb8732f Panel: remove the "toggle location" action in the panel header and move it to menu
f5fc1e0da6 mainThreadDebugService: adopt to success return result of debugService.startDebugging
3a12e6ad32 debug: some comments
9431b96d67 startDebugging method in vscode return true only when start is successful
5e10c95d11 Restructuring DebugService.startDebugging and DebugService.createSession
5a0c4ad7a4 Merge pull request #59604 from Microsoft/sandy081/59603
cf8dac8302 fixes #53325
44cad70136 Update doc
e3797216f9 Activity action should have a name 'activity'
2241e48e17 Merge pull request #59598 from Microsoft/joh/fix59538
98395bd1f5 make sure to always prevent default when clicking links
087ee56e75 fixes #47141
494b385a96 revert "files.guessableEncodings"
caaa5369cb Fix link in workspace notification, fixes #59381
8b3b815396 Fix #59450. Update css for comment decoration.
b472087060 Fix #59316.
e20fdf9545 Signal that TS Server has loaded succesfully when any error event is received
5518b862e6 Bump workspaceContains timeout - #34711
368d3ff0da Pick up TS 3.1 final
64a562a737 update inno updater
723042560f Support odd indentation sizes (fixes #17639)
e1e7c039e2 Do not read Octicons (fixes #58096)
a75f4bcf4e [json] update service (fixes #59470)
b4d09d2750 remove wrong message
33371a88b4 'Type to narrow down results' only for QuickPick (fixes #58105)
e90887a7c0 point macos users failing update to our github link
f586943ea5 propagate update service errors to UI
a7996af3ae debug: fire onDidNewSession when a session restarts
c984412861 fixes #56136
0b90cbbe90 fix #59539
d2d5d79b3a fix #59538
0ebb6b054f Add leading whitespace offset to lookup offset (fixes #59343) (#59537)
807690d8f6 fix #59517
c501691736 fix #59486
a476e33778 remove warnings
0f477b0c58 #59517 Use absolute path
d801626d6c fix #59533
1e1b80843c Register listeners early (fixes #58235)
b3ff2b5e6a tabs - only draw border on one side
0bcd086e53 :lipstick: variable name
dd92ff0b4a #59112 Return file URI
756a4e59e5 #59112 Return string
1bcddf5923 #59112 Return URI
ea03e07018 #59112 Return the downloaded location
eb14a6542f Fix #59112
36f879d818 use .txt extension (for #59302)
f407359b72 fixes #59485
1503b6033e update distro
27086e07b6 tree test
dd26078b15 update distro
6acbbf1bf0 fix #59507
6335da987d Merge commit 'refs/pull/59131/head' of github.com:Microsoft/vscode into pr/59131
58fe02e79b Revert "cancelled git.checkout"
77c8657a86 improve setting description
3aecfeef15 use "readonly"
2291080075 Check for tags before using them Fixes #59229
988297b961 Force search provider ext to activate on search
17cfeaf31e Add better error message about disallowed rename of directory in import path
29e8dcffcf Use rename cancellation token for file rename request to ts server
11c8300bb9 Ensure search cancel takes effect immediately, and still works when search failed
41c47d1b56 Don't rely on updatePathOnFileMove for path renames
ee955d45e3 rebase and remove check in catch
f50b87442c Return whether git.checkout succeeded
a2d3c87982 Fix file path rename for js/ts
f94cfe6677 Make sure javascript.updateImportsOnFileMove.enabled also has enum descriptions
2e95080816 Use markdownEnumDescription for all js/ts enums
9a6d9a0658 Fix args
3d3cbdae58 Fix #59494 - put the setting row measurement element into the same DOM structure as the real tree
b4f4f55f5a Return void instead of comment from editComment, fixes #59460
9906ecc7a5 Disable path renames on TS 3.1
6e9a02177a Fix fileToRename no preserving extension
d8ccc514f5 Remove unneeded any cast
434059aaf6 Fixes #59449, add docs for CommentInfo and CommentThread, rename gravatar to userIconPath
d2fd43d8a2 list view: request scrollable element on next animation frame
cd7726dee7 Fix empty rename error message on uncaught exception in prepareRename
8ea286d92c Fix release notes not showing in product
1ea3f259ed releaseNotesUrl may be undefined on oss builds
39238cb357 add refilter perf stats
8ab24012f8 add todo
a70d87616d working filter demo
6fee1f6e78 tree: more filter testing
0bdfc25951 tree model: refilter
23e8744c68 tree: collapse and expand should refilter
f169056822 Use better name for insertParamtersForFunctionCall setting
6ffd6e8045 Pick up new TS insiders
ca86f0775f Remove unnecessary svgs after settings editor moved to electron-browser
7c27df6b63 improve context view layout
bcad7421ae Add focus offset for buttons
84658f7414 prevent portable in windows setup
f7a4680d93 fix #19400
fd35d99cea Update distro
62c89d3993 Refer to message for a11y (#58105)
5de0fbbb1d Fix #59210
e02fad2a63 fixes #59228
bc6ab9e0f1 Merge branch 'master' of github.com:Microsoft/vscode
cdc21cd886 fixes #59342
b127b2b4e5 label: authority prefix
89a07de60c Merge pull request #59462 from Microsoft/sandy081/59209
0e0fde98d8 changes to visible channel (code review)
eabc2037f8 debug: shutdown session symetric to initialize
92cc41ebd0 Handle relative paths (#58694)
6c6bd52b8e debug: clean up activation events
ece59d53dc build: sequentialize extension packaging
f78b7b2746 #59209 Update output channel when visible
bd0e3aa0cc fix reporter
47bf9b65e8 build
bca9ef4361 fixes #59451
970eb55c35 fixes #58818
23cfe8c27a canSelectMany can be undefined (#51824)
200d30e467 update tsconfig.json to escape node.d.ts hell
72ed1a8b61 fix #59302
b3665b9142 better fix for #58694
bac5061d61 smoke test: fix debug failing test
1bcc3508fa fix #58694
7da2a63c8e fixes #59430
015deacd25 fix #59274
fb50addbe7 fix #59407
f37c890740 fix #59351
cec1733b00 Do not change extensionDevelopmentLocation letter casing
6f60df4d8a fix #59333
ef1a74cdb7 Fix #59429
fd085da0e1 fix NPE for last edit location
8b72d24eda Fix #59392
1871390096 fix #59370
c7dc161efe Fix #59440
495ff68b85 fix #59332
19500141ce fix #35935
638f9d8618 more on #59381
ec452642b3 fix #59341
1f4a61330d fix #59381
5ba5f14c95 add missing svg files
3c4e932329 Fix #59319 - can't use activateByEvent('*') in search
8cdb085627 Fix #59217 - TOC can overlap settings when editor is split
5a89bca0c7 Merge pull request #59413 from Microsoft/alexr00/terminalWarningToInfo
ab002ec2eb Respect the no-icons class in suggestWidget Microsoft/vscode#57380
c4e0ad7e04 Added tags for azure py packages in requirements.txt (#59282)
c091264686 Pick up new TS insiders
89743b1f67 Changed terminal split warn to info
972ee3f948 Use latest applicationinsights in extensions too
c9b88c68cc Update appinsights to latest version
1adea8bd02 Fixed warning when installing on debian 8
479feb5b4f Fixes #59348, Error in editComment/deleteComment not indicated in UI
beebc71b13 Use SelectionClipboard contribution in suggestEnabledInput (#59390)
98151698e6 Fixes #59353, Issue reporter opens multiple issues
c304538114 revert changes
8af2d5cad1 no source maps
010bc0d086 #59209 Flush the content before revealing the channel
7968999638 Fix find when not focused on list
9041e6a4b5 styles for diff on markdown preview (#59289)
a34100d21f #57935 Show recording badge
b96ac3e1dd fixes #58541
cd68ca45c8 wip: first filter test
c38ebd77f5 diff editor is action free (for #59346)
c89cc7e565 wip: propagate filter result to tree nodes
605b95d31c convert diff actions to commands (for #59346)
a5580c3d51 #59322 Remove the options
a4daeb87da tree: introduce filter
515c90a9fe #59082 Reset filter focus on dispose
a2651fefcb Fix #59312
e40a7d2f7b Fix #59311
639c83ba0c tree and list remove getAriaRole since VoiceOver only properly works for tree / treeitem combination
f652102ec2 fixes #59331
8a499f7127 debug service: minor polish
fd189286ae list: properly assign role to every list item
6acd167380 fix #59293
fe41e0fb42 fix #59251
802bd4033f fix #55397
fe8d9d2470 Fix node-debug version
b28af003ef Bump node2 #57954
3da89c1937 Rename previewOptions
1e058b76ea Revert vscode-xterm update
70ac2cfa51 Run oss tool
e574d62f14 Fix potential npe
7d359986ba Use less than for TS version checks instead of inverting greater than checks
484bf49abf Better fix for #58518 to avoid possible duplicated configure requests
58a72ab6cf Don't cache file config options until we succesfully complete a request
54090bc222 Fix #57459 - add default previewOptions for findTextInFiles
5b3403bfb5 Fix #57895 - remove leadingChars from search provider API
5cc3aa24c4 Fixes #52578, Process Explorer: NVDA does not announce CPU% and Memory(MB)
4861c344e2 Fixing tsc build tasks for project references
27ace55a74 Handle Run Active when terminal executible is WSL (#59136)
1369c6e595 Don't send @ as trigger character for ts 3.1
690563da6e Update css language service in html
94f93182c6 Update folding in commenting mode.
32f3f66f7a Fixes #57148: Space in workspaceFolder break task run
dfefc70075 Minimum size for new split terminals (#59140)
5131aa481f Settings: Fix shortcutkey label enabling translation. Fixes #59147 (#59263)
f5738efe91 Fix #59138 - revive URI from findFiles
75f721ff98 vscode-xterm@3.8.0-beta5
34879e95f1 Update CSS service
9fc46b2faf fix for: Cannot read property 'forEach' of null fixes #59227
70b90231ce update built-in dark themes as menus look pale (#59123)
1b2fdd1cbd :lipstick: "Copy Relative Path"
ac7ead397b typing issue & null check in window.ts
6451a30287 Revisit chokidars multi-root handling. fixes #57256
3480f4cf22 restrictGuessedEncodings => guessableEncodings
dacd7728d6 Fixes #40905: Operating system specific args don't override args defined in the task
7a629db352 list focus controller do not focus into elements that have tabIndex -1
eaddbde222 Revisit `QuickPickItem.shouldAlwaysShow` (#59232)
208fc71b7b Merge pull request #59181 from headmelted/patch-1
ab7a507c1b Merge pull request #59236 from Microsoft/isidorn/listAriaRole
2ca5759e82 tree getAriaRole is required
f79b59416b debt - SuggestionType -> SuggestionKind
a28f9bc895 undo fix tests to fix tests
0b463d376e related to #58966
6cdf04d2a5 breakpoint view adopt aria role
641be2e9d7 list aria role
5150d732ea tree accessibilityProvider.getAriaRole
91704613a9 fixes #58966
366c096a9d ignore keywords when sorting by locality #32170
a5a1f74d0e add shared snippet file, add copyright header statement
a981420ed4 fix #59044
b7fbcd14a0 fixes #58057
7b8c3383f9 :lipstick: integration tests
3a3284a8e3 Merge pull request #59224 from Microsoft/joh/dist
a087d3531e merge configuration registries again, don't use whenIdle for contributions
aa2e53f88f Add more trace statements
b862885245 fixes #47141
b38c944383 dirty diff: fix whitespace
ac2bd0a41b use actual word range and block ranges to compute distance
646d6fc6b8 fixes #59218
2427710d02 Merge branch 'master' of github.com:Microsoft/vscode
b8e7d093c4 Fixes #59102: Tasks with scope = the last folder in workspaceFolders array do not show up
56dd8943ce fix #59216
f95e3e3bb4 Fix #59082
29e67955fd fix tests
4244bca7a9 Fix #59209
f429984045 try-catch for build stats telemetry
c5afb67457 debt - move runWhenIdle into browser-layer because it's a browser thing
d47474c557 git init: show picker earlier
39facdaf7c use block count instead of pure line distance
5ea145f161 use Object.create(null)...
f0fd4a1cab Fix #59210
0edcbadbaf :lipstick:
a53164fe10 fixes #58968
e190b866a2 add locality bonus setting
0294604cc7 Fix #42737
9000ab78a5 Fix typos in workbench.editor.labelFormat (#59155)
a488569052 cancelled git.checkout
a5ce878362 Don't open debug panel on run
138acafed8 Fix #58858
ff97e6a99f fix NaN issues
135c659f98 fix #59139
588cfc8b68 #58965 Do not reinstall the extension
97fe5c6096 remove todo
28ba0ff608 use word by lines only
b8d1e278f0 notifications - secondary prompts should close too unless keepOpen is provided
380a502462 :lipstick:
39d87d6d42 :lipstick:
33911f0634 fix #45749
f784085231 address one issue of #59063
79f79a2c97 :lipstick:
40ede4a435 remove todo
80a7897eb8 remove collapse all action
299b111bbf Adding missed dependency libxss1
ae526292df Upgrade appinsights (#58999)
d5d8d98cf3 Add more terminal link test cases
079518239f Search provider - wait for all * activations before searching with provider
0401bcb11f Fix #58441 - keep settings gear button visible when menu is open
7110a8c3cb Fix #57720 - non-file schemes folders not displayed correctly in search viewlet
949adc1528 Use ProviderResult for search providers
a28cb2a39a Fix #58701
905c4ac6f2 Fixes #19819: Write diff editor inline/side-by-side preferences to user settings
bce88d3784 Rename the GUI command title (#55397)
d4ddda413f Fixes #44422: Improve diff hunks merging strategy
caa5334413 Fix #52590 - don't move focus when clicking the search details buttons with screenreader mode turned on. Because NVDA sends click events instead of key events when pressing space. Also update this dynamically for the search option buttons
0469b0089e add toml fixes: #51704 (#59089)
e19c9ba82d Addd option to open markdown preview links in markdown preview
a101ececf4 Remove onCommand from markdown preview
388a62fe12 Fix anchor links in markdown preview
7185906189 Reduce usage of postCommand in markdown preview
47ec1a664e Added special handling of link over tooltip for DOM renderer (#59060)
1ff175f094 Wait to signal to the extHostTerminalService that the terminal is opened until the terminal has a name. (#58983)
4cd9739394 Fix #52274 - don't move focus when clicking the find option buttons with screenreader mode turned on, because NVDA sends click events instead of key events when pressing space on a focused button
529f705935 Announce results of extension search (#59128)
14e1eb32d2 Fix tests
03e0972c85 Remove exec path from process argv reported by issue reporter
2492847b0a Use detailed text for reload button in extension editor (#59074)
c5dd1c60f0 Added new style to handle overflow behavior with find options (#58990)
bd0543890c vscode-xterm@3.8.0-beta4
ab13118d54 Merge pull request #58926 from guywald1/58537-settings-autosave-debounce
a0f1543c00 Fix fileIndex error handling
b5865f62d5 Remove Delayer.fire
1433e180d1 Use a notification for the Screen Reader Mode question instead of custom UI
d4ba91f103 debug: cleanup restart
24224dbd7c Announce extension install,uninstall,update state (#59077)
ad674c3597 fix global access
5c5e503c00 Fixes #55640
f04d2761b1 add word distance (by line) and rank suggestions by that
9fa82e018e Fix #59112
27cb8862c9 fix #24394
20e3a1581e Merge branch 'master' into joh/dist
1ed3678459 debt - in suggest use cancellation token instead of cancelable promise
ac899aa4a2 add getWordRanges call to worker service
63ca867a90 fix #58924
29de7a57fa debug: task method renaming
1fc52c5ee9 debug: debug anyway simplifcation
ff907f33f0 debug: indentation polish
48eaee42b7 fix middle mouse click in quick open
2d08afee54 Tree and list onMiddleMouseClick (#59106)
4c62ac38cf Fixes #55939: Add a limit for writing to the selection clipboard
f3d8bc8244 perf - use `runWhenIdle` for workbench contributions that are registered for phase: eventually
379e077cf2 tree: collapse all
00d5c28999 fix expand tree tests
d3c1eda9a5 Iterator.fromArray
2308643f99 Fixes #41357
b8e4e03b4a debug: do not listen on task active event not needed
f6c98dfa5e remove console log, #58929
ba16f6c1e5 requestIdle - less warning
a2898d57fa implement chooseTab when connecting to the renderer, #58929
67aec4ac0c use requestIdleCallback for Eventually-lifecyclephase
1a492b5c9a Fixes #38832
1b3dc8bee4 fix compile
fde972659f Conditional breakpoint prompt should offer to enable (not disable) breakpoints if breakpoint is already disabled
6f26b8ba85 Fix #58469
db47ba5276 #58469 Move view descriptor collection to view service
8e89438a23 Merge pull request #59092 from noamyogev84/feature_42838
494b5a5622 Allow to navigate to last edit location (#59100)
e25d7ddbf0 fail more graceful when a process cannot be profiled, #58929
27b7b13fb2 Fix context menu retrigger race (#59059)
45200866c0 fixes #58589
cb3dc682b8 modified languageScopeSchema,globalSchema to allow prefix of type array. modified _parseSnippet to push new snippet for each prefix (or for a single one)
f696090156 debug hover: show horizontal scroll for tree
b731fdc2cd fix compile error
1459e9a43d configure snippets offers to create workspace snippets, #8102
94e114335f insert snippet groups by extension, user, and workspace snippets, #8102
47ef4c1f1b add SnippetSource #8102
1e1e9f0a30 debug: there can be a session change event without a stack frame changing, thus we need to listen on both
513025ed9e tab complete - also accept snippets
ab93c7e1bb Merge pull request #58116 from Microsoft/sandy081/outputChannel
3f9707e650 Merge branch 'master' into sandy081/outputChannel
aef6e7ac5e debug issues to isidorn
83dccc6b4e Scope enum for settings more closely
b1b3db9363 Stop updating setting on blur
26f3dcc849 Fix negated logic
6bc7ce6433 Change behavior for non-text inputs
6855b54ae1 Remove redundant async
28307eecb2 code review
d617ede266 Change to options with force parameter
b44b373601 Add test
471204fff4 Fix dirty setting update logic
65277c5e12 Add push option in createOutputChannel API
7c26e93b21 Automatically navigate to the next merge conflict upon resolving a merge conflict
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Refs: #57304
Trigger inteli-sense in the settings input box. Notice the weird icon left of the @
The point of using icons in inteli-sense is to diferentiate items, however since in this use cases all items use the same icon this looses the point.
I have also not seen this icon anywhere else in vscode.
So my recommendation is to remove it
Samo as for extensions input. The icon is just noise
@ramya-rao-a @misolori
The text was updated successfully, but these errors were encountered: