Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watcher: detect the case of mixed path casing and either warn or fix #5904

Closed
bpasero opened this issue Apr 27, 2016 · 4 comments
Closed

Watcher: detect the case of mixed path casing and either warn or fix #5904

bpasero opened this issue Apr 27, 2016 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Milestone
Backlog

Comments

@bpasero
Copy link
Member

bpasero commented Apr 27, 2016

Today when you open VS Code on wrong casing workspace path, all file events stop to work. We should detect this case and either fix it or print a warning.
@bpasero bpasero self-assigned this Apr 27, 2016
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2016
@bpasero bpasero modified the milestones: Backlog, May 2016 Apr 27, 2016
@bpasero bpasero mentioned this issue Apr 29, 2016
Closed
@bpasero bpasero modified the milestones: May 2016, Backlog May 8, 2016
@bpasero bpasero modified the milestones: July 2016, Backlog, June 2016 Jul 2, 2016
@bpasero
Copy link
Member Author

bpasero commented Jul 6, 2016

With the update to Electron 1.2.6, fs.realPath now returns the right casing so this issue should not happen anymore.

@bpasero bpasero closed this as completed Jul 6, 2016
@bpasero bpasero reopened this Jul 8, 2016
@bpasero bpasero modified the milestones: August 2016, July 2016, Backlog Jul 8, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 9, 2016
@bpasero bpasero removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 31, 2016
@bpasero bpasero modified the milestones: September 2016, Backlog Sep 16, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 19, 2016

Duplicate of #1426

@bpasero bpasero closed this as completed Sep 19, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 19, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 22, 2016

Reopening because it looks like node.js 6.4.0 will revert the nice fs.realpath to go back to the previous JS implementation and behaviour.

@bpasero bpasero reopened this Sep 22, 2016
@bpasero bpasero removed *duplicate Issue identified as a duplicate of another issue(s) electron-update labels Sep 22, 2016
@bpasero bpasero modified the milestones: Backlog, September 2016 Sep 22, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 22, 2016

Merging into #12448

@bpasero bpasero closed this as completed Sep 22, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 22, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@bpasero