Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac: file events are not reported when using workspace path with different casing #1426

Closed
bpasero opened this issue Dec 17, 2015 · 4 comments
Closed

Mac: file events are not reported when using workspace path with different casing #1426

bpasero opened this issue Dec 17, 2015 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
February 2017

Comments

@bpasero
Copy link
Member

bpasero commented Dec 17, 2015

Interestingly on Mac when opening VS Code on a workspace path that does not match 100% the casing of the workspace as it is on disk, all file events are not working anymore, even though the rest of the program is functional.

Filed: paulmillr/chokidar#418
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Dec 17, 2015
@bpasero bpasero self-assigned this Dec 17, 2015
@bpasero bpasero added this to the Jan 2016 milestone Dec 17, 2015
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 17, 2015
@bpasero bpasero modified the milestones: Backlog, Jan 2016 Dec 29, 2015
@bpasero bpasero added electron-update and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 31, 2016
@bpasero bpasero modified the milestones: September 2016, Backlog Sep 16, 2016
@bpasero
Copy link
Member Author

bpasero commented Sep 19, 2016

Verify: (Mac only) you can open a folder from the command line into VS Code that uses not the letter casing as it is on disk and you still get file events properly.

@bpasero bpasero closed this as completed Sep 19, 2016
@bpasero bpasero mentioned this issue Sep 19, 2016
Closed
@bpasero
Copy link
Member Author

bpasero commented Sep 22, 2016

Reopening because it looks like node.js 6.4.0 will revert the nice fs.realpath to go back to the previous JS implementation and behaviour.

@bpasero bpasero reopened this Sep 22, 2016
@bpasero bpasero modified the milestones: Backlog, September 2016 Sep 22, 2016
@bpasero bpasero mentioned this issue Sep 22, 2016
Closed
2 tasks
@bpasero
Copy link
Member Author

bpasero commented Sep 22, 2016

Merging into #12448

@bpasero bpasero closed this as completed Sep 22, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 22, 2016
@bpasero bpasero reopened this Feb 4, 2017
@bpasero bpasero removed the *duplicate Issue identified as a duplicate of another issue(s) label Feb 4, 2017
@bpasero bpasero modified the milestones: February 2017, Backlog Feb 4, 2017
bpasero added a commit that referenced this issue Feb 4, 2017
@bpasero
Mac: file events are not reported when using workspace path with diff…
6938ccf 
…erent casing (fixes #1426)
@bpasero bpasero closed this as completed in f1127c9 Feb 6, 2017
@bpasero
Copy link
Member Author

bpasero commented Feb 6, 2017 •
edited
Loading

  • To verify: on macOS run Code on a folder path that is not case identical to the version on disk and verify that you get file events to work (e.g. changes outside are reflected in explorer)

@jrieken jrieken added the verified Verification succeeded label Feb 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
February 2017
Development

No branches or pull requests
2 participants
@bpasero @jrieken