-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal shows corrupt texture sometimes when resuming the OS from a sleep state #69665
Comments
Does this particular flavor of issue happen outside of Linux with NVIDIA Proprietary drivers? It does seem some people report issues with terminal resume on macOS, but NVIDIA's proprietary drivers on Linux seem to have an endemic issue with sleep/resume. |
I think I've seen it on my Macbook (Intel UHD Graphics 630 1536 MB) and my home PC on Windows (GTX 600 series I think). |
I have this too and I'm using the on board video card. Intel HD Graphics 630 |
I resumed from a sleep state and I didn't immediately reproduce this issue. |
@Tyriar you mentioned a "delay between 2 and 3 has to be a while". Is that 2 to 3 hours? My sleep state duration was just under 2 hours |
@chrsmrtn- yeah it's pretty hard to reproduce intentionally |
I've also noted deuteriation of the window. As in initially all is well after my computer wakes back up, but over time artifacts started appearing (using npm packages to host, monitor changes, and auto compile on change). After a while the window flashes and goes black. |
updated to 1809 and again ran into the issue where the terminal text was no longer visible. I could see a cursor, but interacting (even hitting enter to get the command prompt to print out) didn't work. I closed and re-opened the terminal, but no text was displayed. I could get the command prompt to display if I hit enter |
note the above occurred with a working terminal and sleep was not involved. Just like my original ticket that was logged. |
Same weird artefacts after wake-up from sleep on laptop with NVidia graphics card, Ubuntu 16.04 LTS. Reloading window action is required. |
@Tyriar Do you have an idea how to fix it? I could PR.. |
I've pushed e531682 which might be a fix for this problem. For those seeing this a lot could you add this to your settings file and let me know if you still observe the problem:
I can make this the default behavior if it works and doesn't cause any other issues. |
@dinosaurchi was your problem specifically after OS sleep/resume? |
@Tyriar Still reproduces specifically after OS sleep/resume on 1.62.0-insider |
@sguillia @dinosaurchi does it fix itself after resizing the terminal, or only when changing zoom level (ctrl++/ctrl+-)? |
Yes, when I resumed from sleep or simply login back (not sleep), it happened
So far, I fix it by closing the terminal and reopen a new one
Resizing the terminal does not solve the problem in my case |
I guess this is not fixed for some cases then, can you open devtools (Help > Toggle Developer Tools), inspect the terminal and put a screenshot there so we can tell which renderer this is happening on? |
@sguillia oh that's even more interesting, so the webgl renderer fails which I believe just reverts to the DOM renderer for the remainder of the session and that fails for some reason (or it retries?). |
The terminal I left open before suspended my PC Things are good if I start a new terminal using (+) I also have the same issue on my PC with Ubuntu 20.04.2, NVIDIA proprietary drivers but I see a different console log upon inspection of the terminal. Similar to what @sguillia experienced I can zoom in to get the contents back. |
I see this in 1.64.2 via Remote Desktop with the PowerShell Integrated Console.
|
I have had such an issue on Ubuntu18.04 for a long time (maybe two years), the simple solution is just to zoom in/out a bit-- it is not much harmful but rather annoying.. would be good to have some solution |
Still annoying VSCode:
OS: Linux Pop!_OS 21.10 GPU: Nvidia 1080 w/ nvidia-driver-510 Easy to repro (100% reproducible):
|
Since I upgraded to Ubuntu 22.04, my vscode terminal doesn't show the random coloured pixels anymore but text in the console (it seems apart from those fancy ohmyposh prompts) goes missing with the occasional character showing up randomly more like @egaznep first screenshot above). Not sure if it helps, but I have also noticed since the upgrade, Firefox's client area (but not toolbar/tabs/wm frame) started doing the random colours just like the screenshot in the OP when resuming from sleep, or sometimes it just has garbage textures on it, which go away when you click in the client area. It seems like it's maybe not just a vscode/electron/chrome issue but something with graphics drivers or window server or such. Ubuntu 22.04, using GNOME with X11 session, NVidia GeForce GTX 970 with proprietary driver (470) |
Adds canvas renderer texture atlas clearing Fixes microsoft#69665
@codebrainz that was a regression that has since been fixed. Since there haven't been any comments saying this still happens since April I'm going to close this off. Let me know if you see this, and if so run the new Show Terminal Texture Atlas command and upload the image is puts in your workspace root: |
Hi folks, this still seems to be an issue. Zooming IN or OUT fixes it. After suspend, terminal output broken. System: Ubuntu 20.04 LTS AMD Ryzen 5 - NVIDIA GeForce GTX 1060 6GB VGA compatible controller: NVIDIA Corporation GP106 [GeForce GTX 1060 6GB] (rev a1) (prog-if 00 [VGA controller]) |
Workaround: Press ctrl++ and ctrl+- (mac: cmd++, cmd+-) to zoom VS Code in and out which will do a complete redraw of the terminal.
Repro:
What happens exactly differs across machines, I've seen full black, full transparent and things like this:
It seems like both the main terminal canvas texture as well as the texture atlas textures can become corrupted.
The text was updated successfully, but these errors were encountered: