Settings scope toolbar accessibility

[RichCaloggero]

Issue Type: Bug

try and change the "accessibility" setting via keyboard.
When you tab to the setting, NVDA comes out of application mode back to document mode. However, there is no button, link, checkbox, or radio button to interact with. Forcing it back to application mode via insert+spaceBar seems to lose focus.

Part of the issue is that the screen reader can't seem to stay in one mode. This is not a website, so it should stay in application mode throughout. Using a role of application on "main" would force this. In general, this is a bad idea, but this is a true application, so application mode is probably warrented.

Another issue is that toolbars should only be navicable via arrow keys; tab key should take you out of the toolbar to the next (or previous is you use shift+tab) control.

VS Code version: Code - Insiders 1.34.0-insider (0ab39f4, 2019-04-08T05:19:58.162Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 x 3192)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: unavailable_off surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.93GB (11.19GB free)
Process Argv
Screen Reader	yes
VM	0%

Extensions: none We have written the needed data into your clipboard because it was too large to send. Please paste.

[roblourens]

@isidorn do you know anything about this?

Part of the issue is that the screen reader can't seem to stay in one mode. This is not a website, so it should stay in application mode throughout. Using a role of application on "main" would force this. In general, this is a bad idea, but this is a true application, so application mode is probably warrented.

[isidorn]

I do know that NVDA has some modes, they are mentioned here. However I do not know when and how NVDA automatically switched these modes. Somewhat related Stack Overlfow question.

I do not think that NVDA should always be in application mode, I think that defeats the purpose. But @Neurrone or @derekriemer can correct me.

[derekriemer]

I do not think that NVDA should always be in application mode, I think that defeats the purpose. But @Neurrone or @derekriemer can correct me.

In cases where being in browse mode would be useful, either the developer can switch manually (nvda+space) or we can put things in a role of document to automatically switch the user to browse mode. Making an application like vscode have a role of application would solve quite a number of problems such as escape randomly popping the user into browse mode.

[connor4312]

In my testing it seems like in the most recent VS Code:

• Entering the settings view goes into document mode when the "Search settings" input is focused (this is desirable imo)
• Existing document mode no longer loses focus
• I assume the location toolbar (user / workspace / remote) is the one where arrow key navigation was preferred. That problem still seems to exist

[roblourens]

Using this for settings scope toolbar accessibility issues

• Should be navigable with arrow keys
• Needs correct aria labels Screen Reader Cannot Tell If Changing User Or Workspace Settings #97068

[isidorn]

@roblourens is this potentialy a good issue for "help wanted" label?

[rzhao271]

The settings scope toolbar is now navigable with arrow keys. That issue is tracked at #124161.
I still have to confirm whether the aria labels are correct for the scopes.

[isidorn]

@rzhao271 great, let me know if you need help.

[rzhao271]

The current scopes show the following result using NVDA:

User  button  <user-dir-here>\AppData\Roaming\Code - Insiders\User\settings.json
Workspace  button  <workspace-dir-here>\.vscode\settings.json

I'm wondering if that might be too much information, or if the user would just tab to the next/previous element anyway, since the most important info is at the beginning?

[isidorn]

It is good since the most important thing is at the beginning, so the user can skip the path if she is not interested.
I would leave it like that unless we get negative user feedback.