Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: user / workspace switcher keyboard focus is strange #124161

Closed
isidorn opened this issue May 19, 2021 · 1 comment
Closed

Settings: user / workspace switcher keyboard focus is strange #124161

isidorn opened this issue May 19, 2021 · 1 comment
Assignees
@rzhao271
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
October 2021

Comments

@isidorn
Copy link
Contributor

isidorn commented May 19, 2021 •
edited
Loading

There are a couple of issues with the user / workspace switcher in the setting UX

  1. Once the focus is on the User it takes multiple arrow right to focus onto Workspace. The reason for this is most probably that you are using an ActionBar and you mark the invisible sections as disabled and still put them in the ActionBar. Ideally the invisible sections would not even be in the ActionBar however if that is not possible can you try passing focusOnlyEnabledItems: true when creating the ActionBar.
  2. Once the keyboard focus is on Workspace for example and we are showing User they are both decorated the same way and it is confusing

Screenshot 2021-05-19 at 09 56 51

  1. found by @ndarilek
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels May 19, 2021
@roblourens roblourens added this to the Backlog milestone May 19, 2021
@roblourens roblourens assigned rzhao271 and unassigned roblourens Oct 13, 2021
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Oct 13, 2021
rzhao271 added a commit that referenced this issue Oct 13, 2021
@rzhao271
Fix settings tabs widget alignment
c7906b8 
Affects #124161
@rzhao271 rzhao271 modified the milestones: Backlog, October 2021 Oct 13, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Oct 14, 2021

Thanks a lot for fixing this 👏

@rzhao271 rzhao271 mentioned this issue Oct 15, 2021
Closed
@connor4312 connor4312 added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
5 participants
@roblourens @isidorn @connor4312 @rzhao271 and others