Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running build task in Code approximately 50% slower than in terminal #7353

Closed
spongessuck opened this issue Jun 7, 2016 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@spongessuck
Copy link

spongessuck commented Jun 7, 2016

  • VSCode Version: 1.2.0
  • OS Version: Windows 7

Steps to Reproduce:

  1. Run build task in Code (i.e. gulp dist)
  2. Run same command in cmd.exe (or integrated terminal)

Expected result:

  • Tasks should take about the same amount of time

Actual result:

  • Build task takes ~20 seconds to finish in Code, while it takes ~13 seconds in terminal.
@dbaeumer
Copy link
Member

dbaeumer commented Jun 8, 2016

@spongessuck do you have problem matchers installed in your task? Does the task produce lots of output. We are aware of the fact that task with lots of output run slower due to rendering the text in the output panel.

@dbaeumer dbaeumer added tasks Task system issues bug Issue identified by VS Code Team member as probable bug labels Jun 8, 2016
@spongessuck
Copy link
Author

I don't have any problem matchers and the task doesn't produce a lot of
output- maybe 25 lines total or so.

On Wed, Jun 8, 2016, 4:02 AM Dirk Bäumer notifications@github.com wrote:

@spongessuck https://github.com/spongessuck do you have problem
matchers installed in your task? Does the task produce lots of output. We
are aware of the fact that task with lots of output run slower due to
rendering the text in the output panel.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7353 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGE0TnZWpxibaBWe3kXHroqbYlg3Oqoiks5qJnclgaJpZM4IwTxq
.

@dbaeumer
Copy link
Member

dbaeumer commented Nov 7, 2017

I did some measurements using the new terminal runner and here is the outcome

  • executing vscode compile script in a outside terminal => 84 seconds
  • executing vscode compile script in the integrated terminal => 92 seconds
  • executing the vscode compile script in the integrated terminal as a task => 157 seconds :-(

Looking into this the time is spend in the spinner animation. I removed the animation since it adds no value. Without the animation there is no time difference between the task and the integrated terminal.

@dbaeumer dbaeumer closed this as completed Nov 7, 2017
@roblourens roblourens added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants