Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing "code" from Start Menu loads inconsistent/confusing experiences #7619

Closed
kuhlenh opened this issue Jun 13, 2016 · 10 comments
Closed

Typing "code" from Start Menu loads inconsistent/confusing experiences #7619

kuhlenh opened this issue Jun 13, 2016 · 10 comments
Assignees
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone

Comments

@kuhlenh
Copy link

kuhlenh commented Jun 13, 2016

I gave a talk at a .NET meetup the other day and one of the attendees told me he struggled to teach new developers in VS Code because when they type "code" from the Start Menu it flashes a command-line window and then loads VS Code (making them think something failed).

It also has different behavior based on what version of Windows you have (default going to the cmd vs the app):
image
image

@kuhlenh kuhlenh changed the title Typing "code Typing "code" from Start Menu loads inconsistent/confusing experiences Jun 13, 2016
@Tyriar Tyriar added the windows VS Code on Windows issues label Jun 13, 2016
@joaomoreno joaomoreno added this to the Backlog milestone Jun 14, 2016
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jun 14, 2016
@hydranix
Copy link

hydranix commented Jun 15, 2016

could the CALL command be replaced with the START command in code.cmd?

This causes the cmd.exe prompt to exit immediately and only the code.exe window remains open.

@joaomoreno
Copy link
Member

@hydranix: #6608

@aarondandy
Copy link

aarondandy commented Aug 5, 2016

@kuhlenh Thanks for making this issue for me. It is really reassuring to see that us little people are being heard.

@hydranix I tried that on my Windows 10 machine and it totally had the desired results from the start menu and does not appear to affect the command line experience. I did some testing for the environment variables and they do appear to be copied before they are undone by endlocal

start "" "%~dp0..\Code.exe" "%~dp0..\resources\\app\\out\\cli.js" %*

@joaomoreno I was able to replicate the issue that you linked by running that same command with my modified batch file but it still offered the same experience so I don't think it would make that issue any worse.

@joaomoreno
Copy link
Member

As mentioned in #6608, once you switch to start you lose the --wait and --verbose command line flags: the command simply returns immediately.

@aarondandy
Copy link

I missed that but I understand now. Challenge accepted!

@joaomoreno
Copy link
Member

Update from the Windows team:

The code.bat shows up in the best match position 0 as a command (and not as a document). I do agree showing the VS Code app in position 0 instead will be more ideal here.

Note that the ranking of search results is personalized, so if users select the VS Code app the first time they search using the query “code”, all subsequent searches using this query will start showing the app in the top position.

@aarondandy
Copy link

The behavior you describe does not happen on my machine or on any others I have seen. Is that new behavior in a fast ring build? If so, that will solve it in time for most users. I am on 1607 (OS Build 14393.82)

@joaomoreno
Copy link
Member

joaomoreno commented Sep 27, 2016

Reply from the Windows team:

This issue has been fixed since September 8th, the commands are no longer forced to the top.

image

@Tyriar
Copy link
Member

Tyriar commented Sep 30, 2016

Marking upstream as it's a Windows problem.

@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels Sep 30, 2016
@aarondandy
Copy link

I can confirm the fix on my computer as well as the computers of other people I have checked. It is in the wild now.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

5 participants