Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification to the VS code startup batch file for #7619 #10162

Closed
wants to merge 1 commit into from
Closed

Modification to the VS code startup batch file for #7619 #10162

wants to merge 1 commit into from

Conversation

aarondandy
Copy link

This PR is a possible fix for #7619 . It is a simple change to the VS Code batch file. I can't seem to build a proper installer to fully test this change but my code-oss build was able to still launch from the modified batch file. Because my build does not open files I was able to make the same change to the batch file for the real VS Code and was able to open files and directories from the command line using the batch file and running the batch file from the start menu did not leave a blank command window open.

@msftclas
Copy link

msftclas commented Aug 5, 2016

Hi @aarondandy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@joaomoreno
Copy link
Member

joaomoreno commented Aug 5, 2016

Closing due to comment in #7619 and investigation in #6608.

@joaomoreno joaomoreno closed this Aug 5, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants