-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing a conpty terminal can hang the window #76548
Comments
This is causing integration tests to fail under conpty #75689 |
Console team's issue: microsoft/terminal#1810 |
@alexr00 this is caused by inherit cursor position which was a fix for terminals that have already been written to before the process launches (just tasks). We have 2 options to workaround the crashes:
|
Option 1. Conpty is the way of the future and I'd rather we keep finding new bugs there than seeing the same old winpty bugs. |
I'm going to call this fixed in August with this workaround, while a hang likely can still occur it should be very tough to reproduce just with tasks. If people are hitting it they can avoid using the flag completely by configuring the task to not show the intro line and not reuse terminals. |
I'm getting reports that this is still happening with the workaround: |
The upstream issue microsoft/terminal#1810 (comment) was fixed. Will the fix be included in 1.39 or does it depend on Windows update? |
@usernamehw depends on a Windows update and the fix is too complicated to backport. |
Fixed upstream, closing. You may see this until updating to Windows >1903, other windows crashes tracked in #71966 |
Not sure why I reopened this, see #71966 |
microsoft/terminal#1810
The text was updated successfully, but these errors were encountered: