We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When testing #85929
Steps to reproduce:
vscode.workspace.onWillDeleteFiles((e : vscode.FileWillDeleteEvent) => { const p = new Promise((resolve) => { setTimeout(() => resolve(), 10000); }); e.waitUntil(p); console.log(e.files.length); }); vscode.workspace.onDidDeleteFiles((e : vscode.FileDeleteEvent) => { console.log('DELETING...'); e.files.forEach(file => console.log(file)); });
Select multiple files from the explorer with Cmd+Click and delete using context menu.
Cmd+Click
Expect to receive single event fire for all the files but instead the listener is fired individually for each file being deleted.
Output:
1 1 DELETING... <Object> DELETING... <Object>
The text was updated successfully, but these errors were encountered:
The issue is that the file-explorer calls the textFileService per resource. To tackle this we should introduce a bulk call in the textFileService.
Sorry, something went wrong.
This should actually be fixed now with the PR that introduces bulk operations
isidorn
No branches or pull requests
When testing #85929
Steps to reproduce:
Select multiple files from the explorer with
Cmd+Click
and delete using context menu.Expect to receive single event fire for all the files but instead the listener is fired individually for each file being deleted.
Output:
The text was updated successfully, but these errors were encountered: