Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showQuickPick in onDidDeleteFiles doesn't work for multiple deleted files #96274

Closed
ws93 opened this issue Apr 27, 2020 · 2 comments
Closed

showQuickPick in onDidDeleteFiles doesn't work for multiple deleted files #96274

ws93 opened this issue Apr 27, 2020 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@ws93
Copy link

ws93 commented Apr 27, 2020

  • VSCode Version: Version: 1.44.2 (user setup)
    Commit: ff91584
    Date: 2020-04-16T16:36:23.138Z
    Electron: 7.1.11
    Chrome: 78.0.3904.130
    Node.js: 12.8.1
    V8: 7.8.279.23-electron.0
    OS: Windows_NT x64 10.0.18363
  • OS Version: OS: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. Clone my template extension project: https://github.com/ws93/deletefilesapi (The 4-line code I added after yo code)
  2. npm install and then run extension
  3. open a folder that contains multiple files
  4. ctrl select 2 files and right click and delete them
  5. I expect to see 2 quickpickers one by one. But instead, it seems the extension cancelled the first quick pick popup and only shows the second one. The selected item for first quickpicker is undefined.

There's also an issue #86210 with onDidDeleteFiles api that if you ctrl select multiple files and delete them, it will trigger onDidDeleteFiles multiple times instead of having one FileDeleteEvent that contains an array of multiple deleted files.

So I'm not sure if the problem is when the second event got fired it also fired a cancel or esc so it cancelled the first showQuickPick.

Does this issue occur when all extensions are disabled?: Yes

@ws93 ws93 changed the title showQuickPick in onDidDeleteFiles showQuickPick in onDidDeleteFiles doesn't work for multiple deleted files Apr 27, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 28, 2020

This is the same underlying reason as #86210
Once we tackle that, we can look into this one. Until then assigning to backlog.

@isidorn isidorn added feature-request Request for new features or functionality file-explorer Explorer widget issues labels Apr 28, 2020
@isidorn isidorn added this to the Backlog milestone Apr 28, 2020
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @ws93 and others