Allow ThemeIcon in WebviewPanel.iconPath

[ridiculous-thought]

Issue Type: Feature Request

You can only pass an Uri or an object containing Uris to WebviewPanel.iconPath, while iconPath on QuickInputButton and TreeItem also supports ThemeIcon. This would increase codicon reusability.

VS Code version: Code 1.42.0 (ae08d54, 2020-02-06T10:51:34.058Z)
OS version: Windows_NT x64 10.0.18362

[mjbvz]

@bpasero I believe we should change how editors get their icons to support this. My proposal is to add a IEditorInput.icon property that lets editor inputs set their icon directly instead of going through css rules based on the resource. This could also be used for our welcome page and a few other places in VS Code core that have to use css for this today:

vscode/src/vs/workbench/contrib/welcome/page/browser/welcomePage.css

Line 223 in ceb8d83

background-image: url('../../code-icon.svg');

[bpasero]

Works for me.

[mjbvz]

@aeschli Adding you for help with #92122. Let's try looking into this in May

[yiqing-zhao]

Any update? Looking forward to use ThemeIcons in webviews!

[nora-soderlund]

What is the current workaround?

[bpasero]

Now @benibenj introduced support for editors to return a ThemeIcon:

vscode/src/vs/workbench/common/editor/editorInput.ts

Lines 167 to 173 in b487098

	/**
	* Returns the icon which represents this editor input.
	* If undefined, the default icon will be used.
	*/
	getIcon(): ThemeIcon | undefined {
	return undefined;
	}

So I think this can move along, unless I miss something.

[nora-soderlund]

What about setting a ThemeIcon? @bpasero

I might be missing something.

[bpasero]

Yeah I muss the bigger picture of this issue, I was just to mention we made some progress in core for parts of it.