Escaping from a custom menu loses focus

[chrisjj]

1 Tab to this

2 Press Enter

3 Press Esc

Expected: focus returns to '...'
Observed: '...' button disappears and the focus moves to somewhere invisible.

V 1.42.1 on Windows 7.

[isidorn]

This works fine on the mac with native context menus.
The problem is windows and custom menus. Thus renaming and forwarding to @sbatten

[chrisjj]

Thanks. Any idea why Windows native menus are not used?

[isidorn]

They have a lot of issues, for example with accessiblity, thus we use custom menus on Windows.

[chrisjj]

Thanks. I'm surprised Mac has fewer accessibility issues.

[sbatten]

same as #90730, cannot reproduce in master

[eamodio]

I can reproduce this on master

[sbatten]

got it, always show actions setting breaks repro.

[isidorn]

Somewhat similar #91085
When you press esc the focus should ideally return to the outer continer (like the tree does). If that is not possible the focus should not move and stay put.

[isidorn]

Actually that might be the same issue since the custom menu extends from action bar.
What I suggest is the following: in IActionBarOptions we introduce an optional attribute focusOnBlur: HTMLElement that the creators of the actionBar can pass in.
The ActionBar would then pass focus to that element when user presses esc.
Alternative is that all ActionBar users need to listen to onDidCancel event and when the event fires they would pass focus to the appropriate element - similar to what the menu already does.
There are a lot of ActionBar clients and I think all of them need this behavior fixed.

Alternative is just to make esc a no-op in non menu use cases. However I think passing focus to the outer element is actually what the users might expect as @jvesouza points out

Let me know what you think @sbatten @bpasero

[chrisjj]

we introduce an optional attribute focusOnBlur: HTMLElement that the creators of the actionBar can pass in.

Can't you stack the previous holder and then restore?

Alternative is just to make esc a no-op in non menu use cases.

I vote against.

[bpasero]

Alternative is just to make esc a no-op in non menu use cases.

I vote against.

Also, -1 for that. It is relatively simple: check what the OS does when you open a menu and press ESC and mimic that. After all we try to make the menu as close to the native experience as possible.

[sbatten]

fix is likely going to have to involve this #93415 (comment)

[chrisjj]

Closed why?

…

On Wednesday, 27 May 2020, SteVen Batten ***@***.***> wrote: Closed #90729 <#90729> via #97965 <#97965>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#90729 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABO7GEKHJIIGSBHF7CHOSTDRTVKQHANCNFSM4KVR5KJQ> .

[sbatten]

@chrisjj The issue has been resolved with 01b37c6

[chrisjj]

@chrisjj <https://github.com/chrisjj> The issue has been resolved with 01b37c6 <01b37c6>

Great. Thanks.